Re: [PATCH] video: fbdev: sis: use explicitly signed char

2022-10-25 Thread Helge Deller
On 10/25/22 14:55, Jason A. Donenfeld wrote: On Mon, Oct 24, 2022 at 8:29 PM Helge Deller wrote: On 10/24/22 18:29, Jason A. Donenfeld wrote: With char becoming unsigned by default, and with `char` alone being ambiguous and based on architecture, signed chars need to be marked explicitly as

Re: [PATCH] video: fbdev: sis: use explicitly signed char

2022-10-25 Thread Jason A. Donenfeld
On Mon, Oct 24, 2022 at 8:29 PM Helge Deller wrote: > > On 10/24/22 18:29, Jason A. Donenfeld wrote: > > With char becoming unsigned by default, and with `char` alone being > > ambiguous and based on architecture, signed chars need to be marked > > explicitly as such. This fixes warnings like: >

RE: [PATCH] video: fbdev: sis: use explicitly signed char

2022-10-25 Thread David Laight
From: Jason A. Donenfeld > Sent: 24 October 2022 17:29 > To: linux-ker...@vger.kernel.org > > With char becoming unsigned by default, and with `char` alone being > ambiguous and based on architecture, signed chars need to be marked > explicitly as such. This fixes warnings like: > ... > --- >

Re: [PATCH] video: fbdev: sis: use explicitly signed char

2022-10-24 Thread Helge Deller
On 10/24/22 18:29, Jason A. Donenfeld wrote: With char becoming unsigned by default, and with `char` alone being ambiguous and based on architecture, signed chars need to be marked explicitly as such. This fixes warnings like: drivers/video/fbdev/sis/init301.c:3549 SiS_GetCRT2Data301() warn:

[PATCH] video: fbdev: sis: use explicitly signed char

2022-10-24 Thread Jason A. Donenfeld
With char becoming unsigned by default, and with `char` alone being ambiguous and based on architecture, signed chars need to be marked explicitly as such. This fixes warnings like: drivers/video/fbdev/sis/init301.c:3549 SiS_GetCRT2Data301() warn: