Re: [Mesa-dev] [PATCH] wsi_common_display: Deal with vscan values

2018-06-19 Thread Keith Packard
Jason Ekstrand writes: > Looks good. Passes the CTS. Push it! All done. Now just two more series to go in this set :-) -- -keith signature.asc Description: PGP signature ___ dri-devel mailing list dri-devel@lists.freedesktop.org

Re: [Mesa-dev] [PATCH] wsi_common_display: Deal with vscan values

2018-06-19 Thread Jason Ekstrand
On Tue, Jun 19, 2018 at 1:56 PM, Keith Packard wrote: > Jason Ekstrand writes: > > > 1) We weren't setting planeReorderPossible at all and we were using 0 > > instead of VK_FALSE (they're the same but we should use the enum) for > > persistentContent > > 2) We weren't advertising disconnected

Re: [Mesa-dev] [PATCH] wsi_common_display: Deal with vscan values

2018-06-19 Thread Keith Packard
Jason Ekstrand writes: > 1) We weren't setting planeReorderPossible at all and we were using 0 > instead of VK_FALSE (they're the same but we should use the enum) for > persistentContent > 2) We weren't advertising disconnected connectors via > GetPhysicalDeviceDisplayProperties but were

Re: [PATCH] wsi_common_display: Deal with vscan values

2018-06-15 Thread Ville Syrjälä
On Thu, Jun 14, 2018 at 05:57:01PM -0700, Keith Packard wrote: > We sorted out what 'vscan' means and are trying to use it correctly. > > vscan = 0 is the same as vscan = 1, which is slightly annoying; we use > MAX2(vscan, 1) everywhere. > > randr doesn't pass vscan at all, so we set wsi mode

Re: [Mesa-dev] [PATCH] wsi_common_display: Deal with vscan values

2018-06-15 Thread Jason Ekstrand
Before we get too happy to merge things, I ran the CTS tests and there are some failures... I've attached a fixup patch that fixes three bugs I found: 1) We weren't setting planeReorderPossible at all and we were using 0 instead of VK_FALSE (they're the same but we should use the enum) for

Re: [Mesa-dev] [PATCH] wsi_common_display: Deal with vscan values

2018-06-14 Thread Keith Packard
Jason Ekstrand writes: > Looks good to me. With this properly sprinkled on the appropriate patches, > the entire series is > > Reviewed-by: Jason Ekstrand Thanks so much! I've rebased the series onto current master and pushed it back to my gitlab repo here

Re: [Mesa-dev] [PATCH] wsi_common_display: Deal with vscan values

2018-06-14 Thread Jason Ekstrand
Looks good to me. With this properly sprinkled on the appropriate patches, the entire series is Reviewed-by: Jason Ekstrand On Thu, Jun 14, 2018 at 5:57 PM, Keith Packard wrote: > We sorted out what 'vscan' means and are trying to use it correctly. > > vscan = 0 is the same as vscan = 1,

[PATCH] wsi_common_display: Deal with vscan values

2018-06-14 Thread Keith Packard
We sorted out what 'vscan' means and are trying to use it correctly. vscan = 0 is the same as vscan = 1, which is slightly annoying; we use MAX2(vscan, 1) everywhere. randr doesn't pass vscan at all, so we set wsi mode vscan = 0. The doublescan flag doubles the vscan value, so we don't need to