[PATCH -next] dma-buf: heaps: Remove unused variable ret

[Zou Wei]

This patch fixes below warnings reported by coccicheck

./drivers/dma-buf/heaps/heap-helpers.c:202:5-8: Unneeded variable: "ret". 
Return "0" on line 215

Signed-off-by: Zou Wei 
---
 drivers/dma-buf/heaps/heap-helpers.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/dma-buf/heaps/heap-helpers.c 
b/drivers/dma-buf/heaps/heap-helpers.c
index d0696cf..7969510 100644
--- a/drivers/dma-buf/heaps/heap-helpers.c
+++ b/drivers/dma-buf/heaps/heap-helpers.c
@@ -199,7 +199,6 @@ static int dma_heap_dma_buf_begin_cpu_access(struct dma_buf 
*dmabuf,
 {
struct heap_helper_buffer *buffer = dmabuf->priv;
struct dma_heaps_attachment *a;
-   int ret = 0;
 
mutex_lock(>lock);
 
@@ -212,7 +211,7 @@ static int dma_heap_dma_buf_begin_cpu_access(struct dma_buf 
*dmabuf,
}
mutex_unlock(>lock);
 
-   return ret;
+   return 0;
 }
 
 static int dma_heap_dma_buf_end_cpu_access(struct dma_buf *dmabuf,
-- 
2.6.2

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH -next] dma-buf: heaps: Remove unused variable ret

[Sumit Semwal]

Hello Zou,

On Tue, 22 Sep 2020 at 18:12, Christian König  wrote:
>
> Am 22.09.20 um 09:53 schrieb Zou Wei:
> > This patch fixes below warnings reported by coccicheck
> >
> > ./drivers/dma-buf/heaps/heap-helpers.c:202:5-8: Unneeded variable: "ret". 
> > Return "0" on line 215
> >
> > Signed-off-by: Zou Wei 
>
> Acked-by: Christian König 
>
> Going to pick this up for drm-misc-next.
Thanks Christian!
Fwiw, feel free to add my
Acked-by: Sumit Semwal 
>
> > ---
> >   drivers/dma-buf/heaps/heap-helpers.c | 3 +--
> >   1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/drivers/dma-buf/heaps/heap-helpers.c 
> > b/drivers/dma-buf/heaps/heap-helpers.c
> > index d0696cf..7969510 100644
> > --- a/drivers/dma-buf/heaps/heap-helpers.c
> > +++ b/drivers/dma-buf/heaps/heap-helpers.c
> > @@ -199,7 +199,6 @@ static int dma_heap_dma_buf_begin_cpu_access(struct 
> > dma_buf *dmabuf,
> >   {
> >   struct heap_helper_buffer *buffer = dmabuf->priv;
> >   struct dma_heaps_attachment *a;
> > - int ret = 0;
> >
> >   mutex_lock(>lock);
> >
> > @@ -212,7 +211,7 @@ static int dma_heap_dma_buf_begin_cpu_access(struct 
> > dma_buf *dmabuf,
> >   }
> >   mutex_unlock(>lock);
> >
> > - return ret;
> > + return 0;
> >   }
> >
> >   static int dma_heap_dma_buf_end_cpu_access(struct dma_buf *dmabuf,
>

Best,
Sumit.
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH -next] dma-buf: heaps: Remove unused variable ret

[Christian König]

Am 22.09.20 um 09:53 schrieb Zou Wei:

This patch fixes below warnings reported by coccicheck

./drivers/dma-buf/heaps/heap-helpers.c:202:5-8: Unneeded variable: "ret". Return 
"0" on line 215

Signed-off-by: Zou Wei 


Acked-by: Christian König 

Going to pick this up for drm-misc-next.


---
  drivers/dma-buf/heaps/heap-helpers.c | 3 +--
  1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/dma-buf/heaps/heap-helpers.c 
b/drivers/dma-buf/heaps/heap-helpers.c
index d0696cf..7969510 100644
--- a/drivers/dma-buf/heaps/heap-helpers.c
+++ b/drivers/dma-buf/heaps/heap-helpers.c
@@ -199,7 +199,6 @@ static int dma_heap_dma_buf_begin_cpu_access(struct dma_buf 
*dmabuf,
  {
struct heap_helper_buffer *buffer = dmabuf->priv;
struct dma_heaps_attachment *a;
-   int ret = 0;
  
  	mutex_lock(>lock);
  
@@ -212,7 +211,7 @@ static int dma_heap_dma_buf_begin_cpu_access(struct dma_buf *dmabuf,

}
mutex_unlock(>lock);
  
-	return ret;

+   return 0;
  }
  
  static int dma_heap_dma_buf_end_cpu_access(struct dma_buf *dmabuf,


___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel