ping
On 2019/10/9 14:25, zhengbin wrote:
> zhengbin (3):
> drm/amd/display: Remove set but not used variables
> 'bl_pwm_cntl','pwm_period_cntl'
> drm/amd/display: Remove set but not used variable 'value0'
> drm/amd/display: Remove set but not used variables 'regval','speakers'
>
>
Hi Zheng,
Harry's previous comment about the superfluous REG_READ()s is still unaddressed.
Once that's fixed, I can give my r-b.
Thanks,
Leo
On 2019-10-28 5:32 a.m., zhengbin (A) wrote:
> ping
>
> On 2019/10/9 14:25, zhengbin wrote:
>> zhengbin (3):
>> drm/amd/display: Remove set but not
Thanks for the patches.
I think for all of them we should just drop the REG_READ calls
completely. They look like leftovers from when we had a different
register update scheme that would read the register, then update or get
the field value. Now we just use the REG_ macros that will combine the
zhengbin (3):
drm/amd/display: Remove set but not used variables
'bl_pwm_cntl','pwm_period_cntl'
drm/amd/display: Remove set but not used variable 'value0'
drm/amd/display: Remove set but not used variables 'regval','speakers'
drivers/gpu/drm/amd/display/dc/dce/dce_abm.c| 8
