Le mardi 25 août 2020 à 13:30 +0200, Mauro Carvalho Chehab a écrit :
> Em Tue, 25 Aug 2020 05:29:29 +1000
> Dave Airlie escreveu:
>
> > On Thu, 20 Aug 2020 at 20:02, Laurent Pinchart
> > wrote:
> > > Hi Mauro,
> > >
> > > On Thu, Aug 20, 2020 at 09:03:26AM +0200, Mauro Carvalho Chehab wrote:
Hi Mauro.
Laurent and I discussed this driver a little on irc.
Some highlights:
This parts could use register names:
+ writel(0x2, noc_dss_base + 0xc);
+ writel(0x2, noc_dss_base + 0x8c);
+ writel(0x2, noc_dss_base + 0x10c);
+ writel(0x2, noc_dss_base + 0x18c);
The two
Hi Mauro
> Before posting the big patch series again, let me send the new
> version folded into a single patch.
>
> If you'd like to see the entire thing, I'm placing it here:
>
>
> https://gitlab.freedesktop.org/mchehab_kernel/hikey-970/-/commits/hikey970_v2/
Review 3/3
For next
Hi Mauro,
On Tue, 25 Aug 2020 at 12:30, Mauro Carvalho Chehab
wrote:
> Sorry, but I can't agree that review is more important than to be able
> to properly indicate copyrights in a valid way at the legal systems that
> it would apply ;-)
The way to properly indicate copyright coverage is to
Hi Mauro,
On Tue, Aug 25, 2020 at 01:30:25PM +0200, Mauro Carvalho Chehab wrote:
> Em Tue, 25 Aug 2020 05:29:29 +1000
> Dave Airlie escreveu:
>
> > On Thu, 20 Aug 2020 at 20:02, Laurent Pinchart
> > wrote:
> > >
> > > Hi Mauro,
> > >
> > > On Thu, Aug 20, 2020 at 09:03:26AM +0200, Mauro
Em Tue, 25 Aug 2020 05:29:29 +1000
Dave Airlie escreveu:
> On Thu, 20 Aug 2020 at 20:02, Laurent Pinchart
> wrote:
> >
> > Hi Mauro,
> >
> > On Thu, Aug 20, 2020 at 09:03:26AM +0200, Mauro Carvalho Chehab wrote:
> > > Em Wed, 19 Aug 2020 12:52:06 -0700 John Stultz escreveu:
> > > > On Wed,
Hi Mauro
> Before posting the big patch series again, let me send the new
> version folded into a single patch.
Review 2/N
The way output_poll_changed is used to set gpio_mux to select between
the panel and the HDMI looks strange. But I do not know if there is a
more correct way to do it. Other
Hi Mauro
> kirin9xx_fb_panel.h b/drivers/staging/hikey9xx/gpu/kirin9xx_fb_panel.h
> new file mode 100644
> index ..a69c20470f1d
> --- /dev/null
> +++ b/drivers/staging/hikey9xx/gpu/kirin9xx_fb_panel.h
This file is not referenced and should be deleted.
Sam
On Thu, 20 Aug 2020 at 20:02, Laurent Pinchart
wrote:
>
> Hi Mauro,
>
> On Thu, Aug 20, 2020 at 09:03:26AM +0200, Mauro Carvalho Chehab wrote:
> > Em Wed, 19 Aug 2020 12:52:06 -0700 John Stultz escreveu:
> > > On Wed, Aug 19, 2020 at 8:31 AM Laurent Pinchart wrote:
> > > > On Wed, Aug 19, 2020 at
Hi Mauro.
> Before posting the big patch series again, let me send the new
> version folded into a single patch.
Review 1/N
Lots of small details I missed last time.
A good thing is that there is an opportunity to delete som more code.
Sam
> diff --git
Em Fri, 21 Aug 2020 17:56:50 +0200
Sam Ravnborg escreveu:
> Hi Mauro.
>
> On Fri, Aug 21, 2020 at 04:41:58PM +0200, Mauro Carvalho Chehab wrote:
> > Another quick question:
> >
> > Em Wed, 19 Aug 2020 19:35:58 +0200
> > Sam Ravnborg escreveu:
> >
> > > > +#define DSS_REDUCE(x) ((x) > 0 ?
Em Mon, 24 Aug 2020 08:49:30 +0200
Mauro Carvalho Chehab escreveu:
> Hi John,
>
> Em Wed, 19 Aug 2020 20:28:44 -0700
> John Stultz escreveu:
>
>
> > That said even with the patches I've got on top of your series, I
> > still see a few issues:
> > 1) I'm seeing red-blue swap with your driver.
Hi John,
Em Wed, 19 Aug 2020 20:28:44 -0700
John Stultz escreveu:
> That said even with the patches I've got on top of your series, I
> still see a few issues:
> 1) I'm seeing red-blue swap with your driver. I need to dig a bit to
> see what the difference is, I know gralloc has a config
On Wed, 2020-08-19 at 22:48 +0200, Sam Ravnborg wrote:
> And sometimes checkpatch is just wrong.
I'm interested in examples for when checkpatch is "just wrong".
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
Hi Mauro.
On Fri, Aug 21, 2020 at 04:41:58PM +0200, Mauro Carvalho Chehab wrote:
> Another quick question:
>
> Em Wed, 19 Aug 2020 19:35:58 +0200
> Sam Ravnborg escreveu:
>
> > > +#define DSS_REDUCE(x)((x) > 0 ? ((x) - 1) : (x))
> > Use generic macros for this?
>
> Do you know a generic
Hi Mauro.
Thanks for the detailed feedabck.
Two comments in the following.
Sam
>
> > > + ctx->dss_pri_clk = devm_clk_get(dev, "clk_edc0");
> > > + if (!ctx->dss_pri_clk) {
> > > + DRM_ERROR("failed to parse dss_pri_clk\n");
> > > + return -ENODEV;
> > > + }
> ...
>
> > I had
Another quick question:
Em Wed, 19 Aug 2020 19:35:58 +0200
Sam Ravnborg escreveu:
> > +#define DSS_REDUCE(x) ((x) > 0 ? ((x) - 1) : (x))
> Use generic macros for this?
Do you know a generic macro similar to this? Or do you mean adding
it to include/kernel.h?
There are the atomic sub
Em Wed, 19 Aug 2020 19:35:58 +0200
Sam Ravnborg escreveu:
> Also a few high level comments:
Hi Sam,
Finally finished addressing the things you pointed, except by a few
ones:
- bridge bindings;
- use drm_foo() instead of DRM_foo() when possible.
A few answers to some of your
Hi Sam,
Em Wed, 19 Aug 2020 19:35:58 +0200
Sam Ravnborg escreveu:
> > + ret = drm_bridge_attach(encoder, bridge, NULL, 0);
> The bridge should be attached with the falg that tell the bridge NOT to
> create a connector.
>
> The display driver shall created the connector.
>
> Please see how
Hi Mauro.
Quick feedback below.
Sam
On Thu, Aug 20, 2020 at 05:13:22PM +0200, Mauro Carvalho Chehab wrote:
> Em Thu, 20 Aug 2020 16:48:08 +0200
> Sam Ravnborg escreveu:
>
> > Hi Mauro.
> >
> > On Thu, Aug 20, 2020 at 04:06:49PM +0200, Mauro Carvalho Chehab wrote:
> > > Em Wed, 19 Aug
Em Thu, 20 Aug 2020 16:48:08 +0200
Sam Ravnborg escreveu:
> Hi Mauro.
>
> On Thu, Aug 20, 2020 at 04:06:49PM +0200, Mauro Carvalho Chehab wrote:
> > Em Wed, 19 Aug 2020 19:35:58 +0200
> > Sam Ravnborg escreveu:
> >
> > I'm already handling the other comments from your review (I'll send a
> >
Hi Mauro.
On Thu, Aug 20, 2020 at 04:06:49PM +0200, Mauro Carvalho Chehab wrote:
> Em Wed, 19 Aug 2020 19:35:58 +0200
> Sam Ravnborg escreveu:
>
> I'm already handling the other comments from your review (I'll send a
> more complete comment about them after finishing),
If you get back only on
Em Wed, 19 Aug 2020 19:35:58 +0200
Sam Ravnborg escreveu:
I'm already handling the other comments from your review (I'll send a
more complete comment about them after finishing), but I have a doubt
what you meant about this:
> +static int kirin_drm_bind(struct device *dev)
> > +{
> > + struct
Hi Mauro,
On Thu, Aug 20, 2020 at 09:03:26AM +0200, Mauro Carvalho Chehab wrote:
> Em Wed, 19 Aug 2020 12:52:06 -0700 John Stultz escreveu:
> > On Wed, Aug 19, 2020 at 8:31 AM Laurent Pinchart wrote:
> > > On Wed, Aug 19, 2020 at 05:21:20PM +0200, Sam Ravnborg wrote:
> > > > On Wed, Aug 19,
Em Wed, 19 Aug 2020 14:36:52 -0700
John Stultz escreveu:
> On Wed, Aug 19, 2020 at 4:46 AM Mauro Carvalho Chehab
> wrote:
> > So, IMO, the best is to keep it on staging for a while, until those
> > remaining bugs gets solved.
> >
> > I added this series, together with the regulator driver and
>
Em Wed, 19 Aug 2020 20:28:44 -0700
John Stultz escreveu:
> On Wed, Aug 19, 2020 at 7:01 PM John Stultz wrote:
> >
> > On Wed, Aug 19, 2020 at 2:36 PM John Stultz wrote:
> >
> > >
> > > On Wed, Aug 19, 2020 at 4:46 AM Mauro Carvalho Chehab
> > > wrote:
> > > > So, IMO, the best is to keep
Hi Sam,
Em Wed, 19 Aug 2020 22:48:00 +0200
Sam Ravnborg escreveu:
> Hi Mauro.
>
> It seems my review comments failed to reach dri-devel - likely due to
> the size of the mail.
Probably. It reached here properly.
> Link:
>
On 2020-08-19 10:48 p.m., Sam Ravnborg wrote:
> Hi Mauro.
>
> It seems my review comments failed to reach dri-devel - likely due to
> the size of the mail.
Right, some e-mails in this thread went through the dri-devel moderation
queue due to their sizes. This mail of yours did as well, because
Em Wed, 19 Aug 2020 12:52:06 -0700
John Stultz escreveu:
> On Wed, Aug 19, 2020 at 8:31 AM Laurent Pinchart
> wrote:
> > On Wed, Aug 19, 2020 at 05:21:20PM +0200, Sam Ravnborg wrote:
> > > On Wed, Aug 19, 2020 at 01:45:28PM +0200, Mauro Carvalho Chehab wrote:
> > > > This patch series port
Em Wed, 19 Aug 2020 23:25:51 +0200
Sam Ravnborg escreveu:
> Hi John.
>
> > > So, IMO, the best is to keep it on staging for a while, until those
> > > remaining bugs gets solved.
> >
> > I'm not sure I see all of these as compelling for pushing it in via
> > staging. And I suspect in the
Em Wed, 19 Aug 2020 14:13:05 -0700
John Stultz escreveu:
> On Wed, Aug 19, 2020 at 4:46 AM Mauro Carvalho Chehab
> wrote:
> > Yet, I'm submitting it via staging due to the following reasons:
> >
> > - It depends on the LDO3 power supply, which is provided by
> > a regulator driver that it is
On Wed, Aug 19, 2020 at 7:01 PM John Stultz wrote:
>
> On Wed, Aug 19, 2020 at 2:36 PM John Stultz wrote:
> >
> > On Wed, Aug 19, 2020 at 4:46 AM Mauro Carvalho Chehab
> > wrote:
> > > So, IMO, the best is to keep it on staging for a while, until those
> > > remaining bugs gets solved.
> > >
>
On Wed, Aug 19, 2020 at 2:36 PM John Stultz wrote:
>
> On Wed, Aug 19, 2020 at 4:46 AM Mauro Carvalho Chehab
> wrote:
> > So, IMO, the best is to keep it on staging for a while, until those
> > remaining bugs gets solved.
> >
> > I added this series, together with the regulator driver and
> > a
On Wed, Aug 19, 2020 at 4:46 AM Mauro Carvalho Chehab
wrote:
> So, IMO, the best is to keep it on staging for a while, until those
> remaining bugs gets solved.
>
> I added this series, together with the regulator driver and
> a few other patches (including a hack to fix a Kernel 5.8
> regression
Hi John.
> > So, IMO, the best is to keep it on staging for a while, until those
> > remaining bugs gets solved.
>
> I'm not sure I see all of these as compelling for pushing it in via
> staging. And I suspect in the process of submitting the patches for
> review folks may find the cause of some
On Wed, Aug 19, 2020 at 4:46 AM Mauro Carvalho Chehab
wrote:
> Yet, I'm submitting it via staging due to the following reasons:
>
> - It depends on the LDO3 power supply, which is provided by
> a regulator driver that it is currently on staging;
> - Due to legal reasons, I need to preserve the
On Wed, Aug 19, 2020 at 8:31 AM Laurent Pinchart
wrote:
> On Wed, Aug 19, 2020 at 05:21:20PM +0200, Sam Ravnborg wrote:
> > On Wed, Aug 19, 2020 at 01:45:28PM +0200, Mauro Carvalho Chehab wrote:
> > > This patch series port the out-of-tree driver for Hikey 970 (which
> > > should also support
On Wed, Aug 19, 2020 at 05:21:20PM +0200, Sam Ravnborg wrote:
> Hi Mauro.
>
> On Wed, Aug 19, 2020 at 01:45:28PM +0200, Mauro Carvalho Chehab wrote:
> > This patch series port the out-of-tree driver for Hikey 970 (which
> > should also support Hikey 960) from the official 96boards tree:
> >
> >
Hi Mauro.
On Wed, Aug 19, 2020 at 01:45:28PM +0200, Mauro Carvalho Chehab wrote:
> This patch series port the out-of-tree driver for Hikey 970 (which
> should also support Hikey 960) from the official 96boards tree:
>
>https://github.com/96boards-hikey/linux/tree/hikey970-v4.9
>
> Based on
This patch series port the out-of-tree driver for Hikey 970 (which
should also support Hikey 960) from the official 96boards tree:
https://github.com/96boards-hikey/linux/tree/hikey970-v4.9
Based on his history, this driver seems to be originally written
for Kernel 4.4, and was later ported
40 matches
Mail list logo
