Re: [PATCH 01/21] drm/amdgpu: Remove default best_encoder hook from DC

2018-10-05 Thread Leo Li
On 2018-10-05 11:41 AM, Harry Wentland wrote: On 2018-10-04 04:24 PM, Daniel Vetter wrote: For atomic driver this is the default, no need to reimplement it. We still need to keep the copypasta for not-atomic drivers though, since no one polished the legacy crtc helpers as much as the atomic

Re: [PATCH 01/21] drm/amdgpu: Remove default best_encoder hook from DC

2018-10-05 Thread Harry Wentland
On 2018-10-04 04:24 PM, Daniel Vetter wrote: > For atomic driver this is the default, no need to reimplement it. We > still need to keep the copypasta for not-atomic drivers though, since > no one polished the legacy crtc helpers as much as the atomic ones. > > v2: amdgpu uses ->best_encoder

[PATCH 01/21] drm/amdgpu: Remove default best_encoder hook from DC

2018-10-04 Thread Daniel Vetter
For atomic driver this is the default, no need to reimplement it. We still need to keep the copypasta for not-atomic drivers though, since no one polished the legacy crtc helpers as much as the atomic ones. v2: amdgpu uses ->best_encoder internally, give it a local copy. It might be a good idea