Re: [PATCH 01/26] drm/dp_mst: Move link address dumping into a function

2019-08-27 Thread Daniel Vetter
On Mon, Aug 26, 2019 at 05:51:26PM -0400, Lyude Paul wrote: > *sigh* finally have some time to go through these reviews Hey it took me longer to start even reviewing this, and not even through :-( than it took you to reply here. So no worries! > jfyi: I realized after looking over this patch

Re: [PATCH 01/26] drm/dp_mst: Move link address dumping into a function

2019-08-26 Thread Lyude Paul
*sigh* finally have some time to go through these reviews jfyi: I realized after looking over this patch that it's not actually needed - I had been planning on using drm_dp_dump_link_address() for other things, but ended up deciding to make the final plan to use something that dumps into a format

Re: [PATCH 01/26] drm/dp_mst: Move link address dumping into a function

2019-08-08 Thread Daniel Vetter
On Wed, Jul 17, 2019 at 09:42:24PM -0400, Lyude Paul wrote: > Since we're about to be calling this from multiple places. Also it makes > things easier to read! > > Cc: Juston Li > Cc: Imre Deak > Cc: Ville Syrjälä > Cc: Harry Wentland > Signed-off-by: Lyude Paul Reviewed-by: Daniel Vetter

[PATCH 01/26] drm/dp_mst: Move link address dumping into a function

2019-07-17 Thread Lyude Paul
Since we're about to be calling this from multiple places. Also it makes things easier to read! Cc: Juston Li Cc: Imre Deak Cc: Ville Syrjälä Cc: Harry Wentland Signed-off-by: Lyude Paul --- drivers/gpu/drm/drm_dp_mst_topology.c | 35 ++- 1 file changed, 23