Re: [PATCH 01/30] drm: Introduce drm_bridge_init()

2019-11-27 Thread Daniel Vetter
On Wed, Nov 27, 2019 at 11:05:56AM +, Mihail Atanassov wrote: > On Tuesday, 26 November 2019 19:24:45 GMT Sam Ravnborg wrote: > > Hi Mihail. > > Hi Sam, > > > > > > Ack, but with one caveat: bridge->dev is the struct drm_device that is > > > the bridge client, we need to add a

Re: [PATCH 01/30] drm: Introduce drm_bridge_init()

2019-11-27 Thread Mihail Atanassov
On Tuesday, 26 November 2019 19:24:45 GMT Sam Ravnborg wrote: > Hi Mihail. Hi Sam, > > > Ack, but with one caveat: bridge->dev is the struct drm_device that is > > the bridge client, we need to add a bridge->device (patch 29 in this > > series) which is the struct device that will manage the

Re: [PATCH 01/30] drm: Introduce drm_bridge_init()

2019-11-26 Thread Sam Ravnborg
Hi Mihail. > Ack, but with one caveat: bridge->dev is the struct drm_device that is > the bridge client, we need to add a bridge->device (patch 29 in this > series) which is the struct device that will manage the bridge lifetime. Other places uses the variable name "drm" for a drm_device. This is

Re: [PATCH 01/30] drm: Introduce drm_bridge_init()

2019-11-26 Thread Daniel Vetter
On Tue, Nov 26, 2019 at 4:55 PM Mihail Atanassov wrote: > > Hi Daniel, > > Thanks for the quick review. > > On Tuesday, 26 November 2019 14:26:10 GMT Daniel Vetter wrote: > > On Tue, Nov 26, 2019 at 01:15:59PM +, Mihail Atanassov wrote: > > > A simple convenience function to initialize the

Re: [PATCH 01/30] drm: Introduce drm_bridge_init()

2019-11-26 Thread Mihail Atanassov
Hi Daniel, Thanks for the quick review. On Tuesday, 26 November 2019 14:26:10 GMT Daniel Vetter wrote: > On Tue, Nov 26, 2019 at 01:15:59PM +, Mihail Atanassov wrote: > > A simple convenience function to initialize the struct drm_bridge. > > > > Signed-off-by: Mihail Atanassov > > The

Re: [PATCH 01/30] drm: Introduce drm_bridge_init()

2019-11-26 Thread Daniel Vetter
On Tue, Nov 26, 2019 at 01:15:59PM +, Mihail Atanassov wrote: > A simple convenience function to initialize the struct drm_bridge. > > Signed-off-by: Mihail Atanassov The commit message here leaves figuring out why we need this to the reader. Reading ahead the reasons seems to be to roll

[PATCH 01/30] drm: Introduce drm_bridge_init()

2019-11-26 Thread Mihail Atanassov
A simple convenience function to initialize the struct drm_bridge. Signed-off-by: Mihail Atanassov --- drivers/gpu/drm/drm_bridge.c | 29 + include/drm/drm_bridge.h | 4 2 files changed, 33 insertions(+) diff --git a/drivers/gpu/drm/drm_bridge.c