Re: [PATCH 05/12] drm/msm/dpu: in dpu_format replace bitmap with unsigned long field

[Abhinav Kumar]

On 12/2/2023 1:40 PM, Dmitry Baryshkov wrote:

Using bitmap for the flags results in a clumsy syntax on test_bit,
replace it with unsigned long type and simple binary ops.

Signed-off-by: Dmitry Baryshkov 
---
  drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c | 18 +-
  drivers/gpu/drm/msm/disp/dpu1/dpu_hw_mdss.h | 16 +++-
  2 files changed, 16 insertions(+), 18 deletions(-)



Reviewed-by: Abhinav Kumar 

[PATCH 05/12] drm/msm/dpu: in dpu_format replace bitmap with unsigned long field

[Dmitry Baryshkov]

Using bitmap for the flags results in a clumsy syntax on test_bit,
replace it with unsigned long type and simple binary ops.

Signed-off-by: Dmitry Baryshkov 
---
 drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c | 18 +-
 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_mdss.h | 16 +++-
 2 files changed, 16 insertions(+), 18 deletions(-)

diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c 
b/drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c
index 05e82f5dd0e6..3112d85808c7 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c
@@ -45,7 +45,7 @@ bp, flg, fm, np)  
\
.unpack_count = uc,   \
.bpp = bp,\
.fetch_mode = fm, \
-   .flag = {(flg)},  \
+   .flags = flg, \
.num_planes = np, \
.tile_height = DPU_TILE_HEIGHT_DEFAULT\
 }
@@ -64,7 +64,7 @@ alpha, bp, flg, fm, np, th)   
\
.unpack_count = uc,   \
.bpp = bp,\
.fetch_mode = fm, \
-   .flag = {(flg)},  \
+   .flags = flg, \
.num_planes = np, \
.tile_height = th \
 }
@@ -84,7 +84,7 @@ alpha, chroma, count, bp, flg, fm, np)
\
.unpack_count = count,\
.bpp = bp,\
.fetch_mode = fm, \
-   .flag = {(flg)},  \
+   .flags = flg, \
.num_planes = np, \
.tile_height = DPU_TILE_HEIGHT_DEFAULT\
 }
@@ -102,7 +102,7 @@ alpha, chroma, count, bp, flg, fm, np)  
  \
.unpack_count = 2,\
.bpp = 2, \
.fetch_mode = fm, \
-   .flag = {(flg)},  \
+   .flags = flg, \
.num_planes = np, \
.tile_height = DPU_TILE_HEIGHT_DEFAULT\
 }
@@ -121,7 +121,7 @@ flg, fm, np, th)
  \
.unpack_count = 2,\
.bpp = 2, \
.fetch_mode = fm, \
-   .flag = {(flg)},  \
+   .flags = flg, \
.num_planes = np, \
.tile_height = th \
 }
@@ -139,7 +139,7 @@ flg, fm, np, th)
  \
.unpack_count = 2,\
.bpp = 2, \
.fetch_mode = fm, \
-   .flag = {(flg)},  \
+   .flags = flg, \
.num_planes = np, \
.tile_height = DPU_TILE_HEIGHT_DEFAULT\
 }
@@ -158,7 +158,7 @@ flg, fm, np, th)
  \
.unpack_count = 2,\
.bpp = 2, \
.fetch_mode = fm, \
-   .flag = {(flg)},  \
+   .flags = flg, \
.num_planes = np, \
.tile_height = th