Re: [PATCH 06/10] drm/gma500: Move GTT resume logic out of psb_gtt_init()

2022-03-08 Thread Thomas Zimmermann
Hi Am 08.03.22 um 13:07 schrieb Patrik Jakobsson: On Tue, Mar 8, 2022 at 9:48 AM Thomas Zimmermann wrote: Hi Sam and Patrik Am 07.03.22 um 22:02 schrieb Patrik Jakobsson: On Mon, Mar 7, 2022 at 8:07 PM Sam Ravnborg wrote: Hi Thomas, One comment below. On Sun, Mar 06, 2022 at

Re: [PATCH 06/10] drm/gma500: Move GTT resume logic out of psb_gtt_init()

2022-03-08 Thread Patrik Jakobsson
On Tue, Mar 8, 2022 at 9:48 AM Thomas Zimmermann wrote: > > Hi Sam and Patrik > > Am 07.03.22 um 22:02 schrieb Patrik Jakobsson: > > On Mon, Mar 7, 2022 at 8:07 PM Sam Ravnborg wrote: > >> > >> Hi Thomas, > >> > >> One comment below. > >> > >> On Sun, Mar 06, 2022 at 09:36:15PM +0100, Thomas

Re: [PATCH 06/10] drm/gma500: Move GTT resume logic out of psb_gtt_init()

2022-03-08 Thread Thomas Zimmermann
Hi Sam and Patrik Am 07.03.22 um 22:02 schrieb Patrik Jakobsson: On Mon, Mar 7, 2022 at 8:07 PM Sam Ravnborg wrote: Hi Thomas, One comment below. On Sun, Mar 06, 2022 at 09:36:15PM +0100, Thomas Zimmermann wrote: The current implementation of psb_gtt_init() also does resume handling. Move

Re: [PATCH 06/10] drm/gma500: Move GTT resume logic out of psb_gtt_init()

2022-03-07 Thread Patrik Jakobsson
On Mon, Mar 7, 2022 at 8:07 PM Sam Ravnborg wrote: > > Hi Thomas, > > One comment below. > > On Sun, Mar 06, 2022 at 09:36:15PM +0100, Thomas Zimmermann wrote: > > The current implementation of psb_gtt_init() also does resume > > handling. Move the resume code into its own helper. > > > >

Re: [PATCH 06/10] drm/gma500: Move GTT resume logic out of psb_gtt_init()

2022-03-07 Thread Sam Ravnborg
Hi Thomas, One comment below. On Sun, Mar 06, 2022 at 09:36:15PM +0100, Thomas Zimmermann wrote: > The current implementation of psb_gtt_init() also does resume > handling. Move the resume code into its own helper. > > Signed-off-by: Thomas Zimmermann > --- > drivers/gpu/drm/gma500/gtt.c

[PATCH 06/10] drm/gma500: Move GTT resume logic out of psb_gtt_init()

2022-03-06 Thread Thomas Zimmermann
The current implementation of psb_gtt_init() also does resume handling. Move the resume code into its own helper. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/gma500/gtt.c | 122 ++- drivers/gpu/drm/gma500/gtt.h | 2 +-