Re: [PATCH 09/32] auxdisplay/ht16k33: Set FBINFO_VIRTFB flag

[Thomas Zimmermann]

Hi

Am 22.11.23 um 00:50 schrieb Miguel Ojeda:

On Wed, Nov 15, 2023 at 11:30 AM Thomas Zimmermann  wrote:


+   fbdev->info->flags |= FBINFO_VIRTFB;


Is the `|=` (instead of just `=`) used in case someone adds something
to the flags before (e.g. `fb_bl_default_curve`) or due to some other
reason? (One of the other patches uses `=`).


Yes, it's intentionally.



In any case, if that is intended:

Acked-by: Miguel Ojeda 


Thanks.



Cheers,
Miguel


--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)


OpenPGP_signature.asc
Description: OpenPGP digital signature

Re: [PATCH 09/32] auxdisplay/ht16k33: Set FBINFO_VIRTFB flag

[Robin van der Gracht]

On 2023-11-15 11:19, Thomas Zimmermann wrote:

The ht16k33 driver operates on system memory. Mark the framebuffer
accordingly. Helpers operating on the framebuffer memory will test
for the presence of this flag.

Signed-off-by: Thomas Zimmermann 
Cc: Miguel Ojeda 
Cc: Robin van der Gracht 
---
 drivers/auxdisplay/ht16k33.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/auxdisplay/ht16k33.c 
b/drivers/auxdisplay/ht16k33.c

index 3a2d883872249..f1716e3ce6a92 100644
--- a/drivers/auxdisplay/ht16k33.c
+++ b/drivers/auxdisplay/ht16k33.c
@@ -640,6 +640,7 @@ static int ht16k33_fbdev_probe(struct device *dev,
struct ht16k33_priv *priv,

INIT_DELAYED_WORK(>work, ht16k33_fb_update);
fbdev->info->fbops = _fb_ops;
+   fbdev->info->flags |= FBINFO_VIRTFB;
fbdev->info->screen_buffer = fbdev->buffer;
fbdev->info->screen_size = HT16K33_FB_SIZE;
fbdev->info->fix = ht16k33_fb_fix;


Acked-by: Robin van der Gracht 

Re: [PATCH 09/32] auxdisplay/ht16k33: Set FBINFO_VIRTFB flag

[Miguel Ojeda]

On Wed, Nov 15, 2023 at 11:30 AM Thomas Zimmermann  wrote:
>
> +   fbdev->info->flags |= FBINFO_VIRTFB;

Is the `|=` (instead of just `=`) used in case someone adds something
to the flags before (e.g. `fb_bl_default_curve`) or due to some other
reason? (One of the other patches uses `=`).

In any case, if that is intended:

Acked-by: Miguel Ojeda 

Cheers,
Miguel

Re: [PATCH 09/32] auxdisplay/ht16k33: Set FBINFO_VIRTFB flag

[Javier Martinez Canillas]

Thomas Zimmermann  writes:

> The ht16k33 driver operates on system memory. Mark the framebuffer
> accordingly. Helpers operating on the framebuffer memory will test
> for the presence of this flag.
>
> Signed-off-by: Thomas Zimmermann 
> Cc: Miguel Ojeda 
> Cc: Robin van der Gracht 
> ---
>  drivers/auxdisplay/ht16k33.c | 1 +
>  1 file changed, 1 insertion(+)
>

Reviewed-by: Javier Martinez Canillas 

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat

[PATCH 09/32] auxdisplay/ht16k33: Set FBINFO_VIRTFB flag

[Thomas Zimmermann]

The ht16k33 driver operates on system memory. Mark the framebuffer
accordingly. Helpers operating on the framebuffer memory will test
for the presence of this flag.

Signed-off-by: Thomas Zimmermann 
Cc: Miguel Ojeda 
Cc: Robin van der Gracht 
---
 drivers/auxdisplay/ht16k33.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/auxdisplay/ht16k33.c b/drivers/auxdisplay/ht16k33.c
index 3a2d883872249..f1716e3ce6a92 100644
--- a/drivers/auxdisplay/ht16k33.c
+++ b/drivers/auxdisplay/ht16k33.c
@@ -640,6 +640,7 @@ static int ht16k33_fbdev_probe(struct device *dev, struct 
ht16k33_priv *priv,
 
INIT_DELAYED_WORK(>work, ht16k33_fb_update);
fbdev->info->fbops = _fb_ops;
+   fbdev->info->flags |= FBINFO_VIRTFB;
fbdev->info->screen_buffer = fbdev->buffer;
fbdev->info->screen_size = HT16K33_FB_SIZE;
fbdev->info->fix = ht16k33_fb_fix;
-- 
2.42.0