Re: [PATCH 1/1] media: Entities with sink pads must have at least one enabled link

Hi Laurent, Thanks for the comments. On Thu, Nov 15, 2012 at 01:46:23AM +0100, Laurent Pinchart wrote: > On Wednesday 14 November 2012 23:13:45 Sakari Ailus wrote: > > On Wed, Nov 14, 2012 at 10:23:19AM +0100, Sylwester Nawrocki wrote: > > > On 11/13/2012 03:24 PM, Sakari Ailus wrote: > > > > Hi

[PATCH 1/1] media: Entities with sink pads must have at least one enabled link

Hi Laurent, Thanks for the comments. On Thu, Nov 15, 2012 at 01:46:23AM +0100, Laurent Pinchart wrote: > On Wednesday 14 November 2012 23:13:45 Sakari Ailus wrote: > > On Wed, Nov 14, 2012 at 10:23:19AM +0100, Sylwester Nawrocki wrote: > > > On 11/13/2012 03:24 PM, Sakari Ailus wrote: > > > > Hi

[PATCH 1/1] media: Entities with sink pads must have at least one enabled link

Hi Sakari, On Wednesday 14 November 2012 23:13:45 Sakari Ailus wrote: > On Wed, Nov 14, 2012 at 10:23:19AM +0100, Sylwester Nawrocki wrote: > > On 11/13/2012 03:24 PM, Sakari Ailus wrote: > > > Hi all, > > > > > > Comments would be appreciated, either positive or negative. The omap3isp > > > driv

[PATCH 1/1] media: Entities with sink pads must have at least one enabled link

On Wed, Nov 14, 2012 at 11:58:42AM +0100, Laurent Pinchart wrote: > I think my preference would go for a helper function that drivers can use, > possibly first waiting until a second driver requires this kind of checks > before implementing it. I'd like to see a driver that doesn't. Quite likely

[PATCH 1/1] media: Entities with sink pads must have at least one enabled link

Hi Sylwester, Thanks for the comments. On Wed, Nov 14, 2012 at 10:23:19AM +0100, Sylwester Nawrocki wrote: > On 11/13/2012 03:24 PM, Sakari Ailus wrote: > > Hi all, > > > > Comments would be appreciated, either positive or negative. The omap3isp > > driver does the same check itself currently, b

Re: [PATCH 1/1] media: Entities with sink pads must have at least one enabled link

On Wed, Nov 14, 2012 at 11:58:42AM +0100, Laurent Pinchart wrote: > I think my preference would go for a helper function that drivers can use, > possibly first waiting until a second driver requires this kind of checks > before implementing it. I'd like to see a driver that doesn't. Quite likely

Re: [PATCH 1/1] media: Entities with sink pads must have at least one enabled link

Hi Sylwester, Thanks for the comments. On Wed, Nov 14, 2012 at 10:23:19AM +0100, Sylwester Nawrocki wrote: > On 11/13/2012 03:24 PM, Sakari Ailus wrote: > > Hi all, > > > > Comments would be appreciated, either positive or negative. The omap3isp > > driver does the same check itself currently, b

Re: [PATCH 1/1] media: Entities with sink pads must have at least one enabled link

Hi Sakari, On Wednesday 14 November 2012 23:13:45 Sakari Ailus wrote: > On Wed, Nov 14, 2012 at 10:23:19AM +0100, Sylwester Nawrocki wrote: > > On 11/13/2012 03:24 PM, Sakari Ailus wrote: > > > Hi all, > > > > > > Comments would be appreciated, either positive or negative. The omap3isp > > > driv

[PATCH 1/1] media: Entities with sink pads must have at least one enabled link

Hi Sylwester, On Wednesday 14 November 2012 10:23:19 Sylwester Nawrocki wrote: > On 11/13/2012 03:24 PM, Sakari Ailus wrote: > > Hi all, > > > > Comments would be appreciated, either positive or negative. The omap3isp > > driver does the same check itself currently, but I think this is more > > g

[PATCH 1/1] media: Entities with sink pads must have at least one enabled link

Hi Sakari, On 11/13/2012 03:24 PM, Sakari Ailus wrote: > Hi all, > > Comments would be appreciated, either positive or negative. The omap3isp > driver does the same check itself currently, but I think this is more > generic than that. > > Thanks. > > On Fri, Oct 26, 2012 at 10:46:17PM +0300, Sa

Re: [PATCH 1/1] media: Entities with sink pads must have at least one enabled link

Hi Sylwester, On Wednesday 14 November 2012 10:23:19 Sylwester Nawrocki wrote: > On 11/13/2012 03:24 PM, Sakari Ailus wrote: > > Hi all, > > > > Comments would be appreciated, either positive or negative. The omap3isp > > driver does the same check itself currently, but I think this is more > > g

Re: [PATCH 1/1] media: Entities with sink pads must have at least one enabled link

Hi Sakari, On 11/13/2012 03:24 PM, Sakari Ailus wrote: > Hi all, > > Comments would be appreciated, either positive or negative. The omap3isp > driver does the same check itself currently, but I think this is more > generic than that. > > Thanks. > > On Fri, Oct 26, 2012 at 10:46:17PM +0300, Sa

[PATCH 1/1] media: Entities with sink pads must have at least one enabled link

Hi all, Comments would be appreciated, either positive or negative. The omap3isp driver does the same check itself currently, but I think this is more generic than that. Thanks. On Fri, Oct 26, 2012 at 10:46:17PM +0300, Sakari Ailus wrote: > If an entity has sink pads, at least one of them must

Re: [PATCH 1/1] media: Entities with sink pads must have at least one enabled link

Hi all, Comments would be appreciated, either positive or negative. The omap3isp driver does the same check itself currently, but I think this is more generic than that. Thanks. On Fri, Oct 26, 2012 at 10:46:17PM +0300, Sakari Ailus wrote: > If an entity has sink pads, at least one of them must

[PATCH 1/1] media: Entities with sink pads must have at least one enabled link

If an entity has sink pads, at least one of them must be connected to another pad with an enabled link. If a driver with multiple sink pads has more strict requirements the check should be done in the driver itself. Just requiring one sink pad is connected with an enabled link is enough API-wise:

[PATCH 1/1] media: Entities with sink pads must have at least one enabled link

If an entity has sink pads, at least one of them must be connected to another pad with an enabled link. If a driver with multiple sink pads has more strict requirements the check should be done in the driver itself. Just requiring one sink pad is connected with an enabled link is enough API-wise: