Re: [PATCH 1/2] drm/msm/gpu: Wait for idle before suspending

2022-01-08 Thread Rob Clark
On Fri, Jan 7, 2022 at 4:27 PM Stephen Boyd wrote: > > Quoting Rob Clark (2022-01-06 10:14:46) > > From: Rob Clark > > > > System suspend uses pm_runtime_force_suspend(), which cheekily bypasses > > the runpm reference counts. This doesn't actually work so well when the > > GPU is active. So

Re: [PATCH 1/2] drm/msm/gpu: Wait for idle before suspending

2022-01-07 Thread Stephen Boyd
Quoting Rob Clark (2022-01-06 10:14:46) > From: Rob Clark > > System suspend uses pm_runtime_force_suspend(), which cheekily bypasses > the runpm reference counts. This doesn't actually work so well when the > GPU is active. So add a reasonable delay waiting for the GPU to become > idle. Maybe

Re: [PATCH 1/2] drm/msm/gpu: Wait for idle before suspending

2022-01-07 Thread AngeloGioacchino Del Regno
Il 06/01/22 19:14, Rob Clark ha scritto: From: Rob Clark System suspend uses pm_runtime_force_suspend(), which cheekily bypasses the runpm reference counts. This doesn't actually work so well when the GPU is active. So add a reasonable delay waiting for the GPU to become idle. Alternatively

Re: [PATCH 1/2] drm/msm/gpu: Wait for idle before suspending

2022-01-06 Thread Bjorn Andersson
On Thu 06 Jan 10:14 PST 2022, Rob Clark wrote: > From: Rob Clark > > System suspend uses pm_runtime_force_suspend(), which cheekily bypasses > the runpm reference counts. This doesn't actually work so well when the > GPU is active. So add a reasonable delay waiting for the GPU to become >

[PATCH 1/2] drm/msm/gpu: Wait for idle before suspending

2022-01-06 Thread Rob Clark
From: Rob Clark System suspend uses pm_runtime_force_suspend(), which cheekily bypasses the runpm reference counts. This doesn't actually work so well when the GPU is active. So add a reasonable delay waiting for the GPU to become idle. Alternatively we could just return -EBUSY in this case,