Re: [Intel-gfx] [PATCH 1/3] drm/atomic-helpers: remove legacy_cursor_update hacks

2020-10-23 Thread Rob Clark
On Fri, Oct 23, 2020 at 9:00 AM Daniel Vetter wrote: > > On Fri, Oct 23, 2020 at 5:02 PM Rob Clark wrote: > > > > On Thu, Oct 22, 2020 at 12:16 PM Daniel Vetter > > wrote: > > > > > > On Thu, Oct 22, 2020 at 7:22 PM Rob Clark wrote: > > > > > > > > On Thu, Oct 22, 2020 at 10:02 AM Rob Clark

Re: [Intel-gfx] [PATCH 1/3] drm/atomic-helpers: remove legacy_cursor_update hacks

2020-10-23 Thread Daniel Vetter
On Fri, Oct 23, 2020 at 5:02 PM Rob Clark wrote: > > On Thu, Oct 22, 2020 at 12:16 PM Daniel Vetter wrote: > > > > On Thu, Oct 22, 2020 at 7:22 PM Rob Clark wrote: > > > > > > On Thu, Oct 22, 2020 at 10:02 AM Rob Clark wrote: > > > > > > > > On Wed, Oct 21, 2020 at 9:32 AM Daniel Vetter > >

Re: [Intel-gfx] [PATCH 1/3] drm/atomic-helpers: remove legacy_cursor_update hacks

2020-10-23 Thread Rob Clark
On Thu, Oct 22, 2020 at 12:16 PM Daniel Vetter wrote: > > On Thu, Oct 22, 2020 at 7:22 PM Rob Clark wrote: > > > > On Thu, Oct 22, 2020 at 10:02 AM Rob Clark wrote: > > > > > > On Wed, Oct 21, 2020 at 9:32 AM Daniel Vetter > > > wrote: > > > > > > > > The stuff never really worked, and leads

[PATCH 1/3] drm/atomic-helpers: remove legacy_cursor_update hacks

2020-10-23 Thread Daniel Vetter
The stuff never really worked, and leads to lots of fun because it out-of-order frees atomic states. Which upsets KASAN, among other things. For async updates we now have a more solid solution with the ->atomic_async_check and ->atomic_async_commit hooks. Support for that for msm and vc4 landed.

Re: [Intel-gfx] [PATCH 1/3] drm/atomic-helpers: remove legacy_cursor_update hacks

2020-10-22 Thread Daniel Vetter
On Thu, Oct 22, 2020 at 7:22 PM Rob Clark wrote: > > On Thu, Oct 22, 2020 at 10:02 AM Rob Clark wrote: > > > > On Wed, Oct 21, 2020 at 9:32 AM Daniel Vetter > > wrote: > > > > > > The stuff never really worked, and leads to lots of fun because it > > > out-of-order frees atomic states. Which

Re: [Intel-gfx] [PATCH 1/3] drm/atomic-helpers: remove legacy_cursor_update hacks

2020-10-22 Thread Rob Clark
On Thu, Oct 22, 2020 at 10:02 AM Rob Clark wrote: > > On Wed, Oct 21, 2020 at 9:32 AM Daniel Vetter wrote: > > > > The stuff never really worked, and leads to lots of fun because it > > out-of-order frees atomic states. Which upsets KASAN, among other > > things. > > > > For async updates we now

Re: [Intel-gfx] [PATCH 1/3] drm/atomic-helpers: remove legacy_cursor_update hacks

2020-10-22 Thread Rob Clark
On Wed, Oct 21, 2020 at 9:32 AM Daniel Vetter wrote: > > The stuff never really worked, and leads to lots of fun because it > out-of-order frees atomic states. Which upsets KASAN, among other > things. > > For async updates we now have a more solid solution with the > ->atomic_async_check and

Re: [PATCH 1/3] drm/atomic-helpers: remove legacy_cursor_update hacks

2020-10-22 Thread Daniel Vetter
On Thu, Oct 22, 2020 at 09:36:23AM -0400, Kazlauskas, Nicholas wrote: > On 2020-10-21 12:32 p.m., Daniel Vetter wrote: > > The stuff never really worked, and leads to lots of fun because it > > out-of-order frees atomic states. Which upsets KASAN, among other > > things. > > > > For async updates

Re: [PATCH 1/3] drm/atomic-helpers: remove legacy_cursor_update hacks

2020-10-22 Thread Kazlauskas, Nicholas
On 2020-10-21 12:32 p.m., Daniel Vetter wrote: The stuff never really worked, and leads to lots of fun because it out-of-order frees atomic states. Which upsets KASAN, among other things. For async updates we now have a more solid solution with the ->atomic_async_check and ->atomic_async_commit

[PATCH 1/3] drm/atomic-helpers: remove legacy_cursor_update hacks

2020-10-21 Thread Daniel Vetter
The stuff never really worked, and leads to lots of fun because it out-of-order frees atomic states. Which upsets KASAN, among other things. For async updates we now have a more solid solution with the ->atomic_async_check and ->atomic_async_commit hooks. Support for that for msm and vc4 landed.