Re: [PATCH 1/3] drm/panel: Rename Sony ACX424 to Novatek NT35560

2022-02-19 Thread Sam Ravnborg
On Mon, Jan 03, 2022 at 12:38:20PM +0100, Linus Walleij wrote:
> A code drop from Sony Mobile reveals that the ACX424 panels are
> built around the Novatek NT35560 panel controllers so just bite
> the bullet and rename the driver and all basic symbols so that
> we can modify this driver to cover any other panels also using
> the Novatek NT35560 display controller.
> 
> Signed-off-by: Linus Walleij 
Acked-by: Sam Ravnborg 


Re: [PATCH 1/3] drm/panel: Rename Sony ACX424 to Novatek NT35560

2022-02-19 Thread Sam Ravnborg
Hi Linus,

On Sat, Feb 19, 2022 at 02:40:33AM +0100, Linus Walleij wrote:
> On Sat, Jan 29, 2022 at 2:26 AM Linus Walleij  
> wrote:
> > On Mon, Jan 3, 2022 at 12:40 PM Linus Walleij  
> > wrote:
> >
> > > A code drop from Sony Mobile reveals that the ACX424 panels are
> > > built around the Novatek NT35560 panel controllers so just bite
> > > the bullet and rename the driver and all basic symbols so that
> > > we can modify this driver to cover any other panels also using
> > > the Novatek NT35560 display controller.
> > >
> > > Signed-off-by: Linus Walleij 
> >
> > Could someone take mercy in reviewing this patch set?
> >
> > I can offer some patch review back!
> 
> I can also offer coffee in person in Sweden,
I will take you up on this on day - I hope :-)
Greetings from Denmark.

Sam


Re: [PATCH 1/3] drm/panel: Rename Sony ACX424 to Novatek NT35560

2022-02-18 Thread Linus Walleij
On Sat, Jan 29, 2022 at 2:26 AM Linus Walleij  wrote:
> On Mon, Jan 3, 2022 at 12:40 PM Linus Walleij  
> wrote:
>
> > A code drop from Sony Mobile reveals that the ACX424 panels are
> > built around the Novatek NT35560 panel controllers so just bite
> > the bullet and rename the driver and all basic symbols so that
> > we can modify this driver to cover any other panels also using
> > the Novatek NT35560 display controller.
> >
> > Signed-off-by: Linus Walleij 
>
> Could someone take mercy in reviewing this patch set?
>
> I can offer some patch review back!

I can also offer coffee in person in Sweden, some Star
Wars memorabilia or used mobile phones.

The patches aren't really big, just moving and renaming.

Yours,
Linus Walleij


Re: [PATCH 1/3] drm/panel: Rename Sony ACX424 to Novatek NT35560

2022-01-28 Thread Linus Walleij
On Mon, Jan 3, 2022 at 12:40 PM Linus Walleij  wrote:

> A code drop from Sony Mobile reveals that the ACX424 panels are
> built around the Novatek NT35560 panel controllers so just bite
> the bullet and rename the driver and all basic symbols so that
> we can modify this driver to cover any other panels also using
> the Novatek NT35560 display controller.
>
> Signed-off-by: Linus Walleij 

Could someone take mercy in reviewing this patch set?

I can offer some patch review back!

Yours,
Linus Walleij


[PATCH 1/3] drm/panel: Rename Sony ACX424 to Novatek NT35560

2022-01-03 Thread Linus Walleij
A code drop from Sony Mobile reveals that the ACX424 panels are
built around the Novatek NT35560 panel controllers so just bite
the bullet and rename the driver and all basic symbols so that
we can modify this driver to cover any other panels also using
the Novatek NT35560 display controller.

Signed-off-by: Linus Walleij 
---
 MAINTAINERS   |  13 +-
 drivers/gpu/drm/panel/Kconfig |  23 +-
 drivers/gpu/drm/panel/Makefile|   2 +-
 ...ny-acx424akp.c => panel-novatek-nt35560.c} | 215 +-
 4 files changed, 129 insertions(+), 124 deletions(-)
 rename drivers/gpu/drm/panel/{panel-sony-acx424akp.c => 
panel-novatek-nt35560.c} (57%)

diff --git a/MAINTAINERS b/MAINTAINERS
index 7a2345ce8521..631e68ae923a 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -6054,6 +6054,13 @@ T:   git git://anongit.freedesktop.org/drm/drm-misc
 F: Documentation/devicetree/bindings/display/panel/novatek,nt35510.yaml
 F: drivers/gpu/drm/panel/panel-novatek-nt35510.c
 
+DRM DRIVER FOR NOVATEK NT35560 PANELS
+M: Linus Walleij 
+S: Maintained
+T: git git://anongit.freedesktop.org/drm/drm-misc
+F: Documentation/devicetree/bindings/display/panel/sony,acx424akp.yaml
+F: drivers/gpu/drm/panel/panel-novatek-nt35560.c
+
 DRM DRIVER FOR NOVATEK NT36672A PANELS
 M: Sumit Semwal 
 S: Maintained
@@ -6171,12 +6178,6 @@ T:   git git://anongit.freedesktop.org/drm/drm-misc
 F: Documentation/devicetree/bindings/display/sitronix,st7735r.yaml
 F: drivers/gpu/drm/tiny/st7735r.c
 
-DRM DRIVER FOR SONY ACX424AKP PANELS
-M: Linus Walleij 
-S: Maintained
-T: git git://anongit.freedesktop.org/drm/drm-misc
-F: drivers/gpu/drm/panel/panel-sony-acx424akp.c
-
 DRM DRIVER FOR ST-ERICSSON MCDE
 M: Linus Walleij 
 S: Maintained
diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
index cfc8d644cedf..f6b54fd41d85 100644
--- a/drivers/gpu/drm/panel/Kconfig
+++ b/drivers/gpu/drm/panel/Kconfig
@@ -272,6 +272,18 @@ config DRM_PANEL_NOVATEK_NT35510
  around the Novatek NT35510 display controller, such as some
  Hydis panels.
 
+config DRM_PANEL_NOVATEK_NT35560
+   tristate "Novatek NT35560 DSI command mode panel"
+   depends on OF
+   depends on DRM_MIPI_DSI
+   depends on BACKLIGHT_CLASS_DEVICE
+   select VIDEOMODE_HELPERS
+   help
+ Say Y here if you want to enable the Novatek NT35560 display
+ controller. This panel supports DSI in both command and video
+ mode. This supports several panels such as Sony ACX424AKM and
+ ACX424AKP.
+
 config DRM_PANEL_NOVATEK_NT36672A
tristate "Novatek NT36672A DSI panel"
depends on OF
@@ -561,17 +573,6 @@ config DRM_PANEL_SITRONIX_ST7789V
  Say Y here if you want to enable support for the Sitronix
  ST7789V controller for 240x320 LCD panels
 
-config DRM_PANEL_SONY_ACX424AKP
-   tristate "Sony ACX424AKP DSI command mode panel"
-   depends on OF
-   depends on DRM_MIPI_DSI
-   depends on BACKLIGHT_CLASS_DEVICE
-   select VIDEOMODE_HELPERS
-   help
- Say Y here if you want to enable the Sony ACX424 display
- panel. This panel supports DSI in both command and video
- mode.
-
 config DRM_PANEL_SONY_ACX565AKM
tristate "Sony ACX565AKM panel"
depends on GPIOLIB && OF && SPI
diff --git a/drivers/gpu/drm/panel/Makefile b/drivers/gpu/drm/panel/Makefile
index bca4cc1f2715..540e303a90c5 100644
--- a/drivers/gpu/drm/panel/Makefile
+++ b/drivers/gpu/drm/panel/Makefile
@@ -25,6 +25,7 @@ obj-$(CONFIG_DRM_PANEL_LG_LB035Q02) += panel-lg-lb035q02.o
 obj-$(CONFIG_DRM_PANEL_LG_LG4573) += panel-lg-lg4573.o
 obj-$(CONFIG_DRM_PANEL_NEC_NL8048HL11) += panel-nec-nl8048hl11.o
 obj-$(CONFIG_DRM_PANEL_NOVATEK_NT35510) += panel-novatek-nt35510.o
+obj-$(CONFIG_DRM_PANEL_NOVATEK_NT35560) += panel-novatek-nt35560.o
 obj-$(CONFIG_DRM_PANEL_NOVATEK_NT36672A) += panel-novatek-nt36672a.o
 obj-$(CONFIG_DRM_PANEL_NOVATEK_NT39016) += panel-novatek-nt39016.o
 obj-$(CONFIG_DRM_PANEL_MANTIX_MLAF057WE51) += panel-mantix-mlaf057we51.o
@@ -57,7 +58,6 @@ obj-$(CONFIG_DRM_PANEL_SHARP_LS060T1SX01) += 
panel-sharp-ls060t1sx01.o
 obj-$(CONFIG_DRM_PANEL_SITRONIX_ST7701) += panel-sitronix-st7701.o
 obj-$(CONFIG_DRM_PANEL_SITRONIX_ST7703) += panel-sitronix-st7703.o
 obj-$(CONFIG_DRM_PANEL_SITRONIX_ST7789V) += panel-sitronix-st7789v.o
-obj-$(CONFIG_DRM_PANEL_SONY_ACX424AKP) += panel-sony-acx424akp.o
 obj-$(CONFIG_DRM_PANEL_SONY_ACX565AKM) += panel-sony-acx565akm.o
 obj-$(CONFIG_DRM_PANEL_TDO_TL070WSH30) += panel-tdo-tl070wsh30.o
 obj-$(CONFIG_DRM_PANEL_TPO_TD028TTEC1) += panel-tpo-td028ttec1.o
diff --git a/drivers/gpu/drm/panel/panel-sony-acx424akp.c 
b/drivers/gpu/drm/panel/panel-novatek-nt35560.c
similarity index 57%
rename from drivers/gpu/drm/panel/panel-sony-acx424akp.c
rename to drivers/gpu/drm/panel/panel-novatek-nt35560.c
index