Re: [Intel-gfx] [PATCH 1/4] drm/i915: Wait for LVDS panel power sequence

2011-08-08 Thread Jesse Barnes
On Mon, 08 Aug 2011 11:40:06 -0700 Keith Packard wrote: > On Mon, 8 Aug 2011 09:27:19 -0700, Jesse Barnes > wrote: > > > ...to catch places like this where the wrong register gets used. :) > > Ouch! There are only two places we *should* have these loops, one when > turning it off, another whe

[Intel-gfx] [PATCH 1/4] drm/i915: Wait for LVDS panel power sequence

2011-08-08 Thread Jesse Barnes
On Mon, 08 Aug 2011 11:40:06 -0700 Keith Packard wrote: > On Mon, 8 Aug 2011 09:27:19 -0700, Jesse Barnes > wrote: > > > ...to catch places like this where the wrong register gets used. :) > > Ouch! There are only two places we *should* have these loops, one when > turning it off, another whe

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Wait for LVDS panel power sequence

2011-08-08 Thread Keith Packard
On Mon, 8 Aug 2011 09:27:19 -0700, Jesse Barnes wrote: > ...to catch places like this where the wrong register gets used. :) Ouch! There are only two places we *should* have these loops, one when turning it off, another when turning it on. There's a couple of loops which just need to be removed

[Intel-gfx] [PATCH 1/4] drm/i915: Wait for LVDS panel power sequence

2011-08-08 Thread Keith Packard
On Mon, 8 Aug 2011 09:27:19 -0700, Jesse Barnes wrote: > ...to catch places like this where the wrong register gets used. :) Ouch! There are only two places we *should* have these loops, one when turning it off, another when turning it on. There's a couple of loops which just need to be removed

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Wait for LVDS panel power sequence

2011-08-08 Thread Jesse Barnes
On Sat, 6 Aug 2011 10:54:05 -0700 Keith Packard wrote: > During mode setting, check to make sure the panel power sequencing has > completed before doing further operations on the device. This > uncovered errors with DPMS not turning the device off as it was left locked. > > Signed-off-by: Keith

[Intel-gfx] [PATCH 1/4] drm/i915: Wait for LVDS panel power sequence

2011-08-08 Thread Jesse Barnes
On Sat, 6 Aug 2011 10:54:05 -0700 Keith Packard wrote: > During mode setting, check to make sure the panel power sequencing has > completed before doing further operations on the device. This > uncovered errors with DPMS not turning the device off as it was left locked. > > Signed-off-by: Keith

[PATCH 1/4] drm/i915: Wait for LVDS panel power sequence

2011-08-06 Thread Keith Packard
During mode setting, check to make sure the panel power sequencing has completed before doing further operations on the device. This uncovered errors with DPMS not turning the device off as it was left locked. Signed-off-by: Keith Packard --- drivers/gpu/drm/i915/intel_lvds.c | 13 +++-

[PATCH 1/4] drm/i915: Wait for LVDS panel power sequence

2011-08-06 Thread Keith Packard
During mode setting, check to make sure the panel power sequencing has completed before doing further operations on the device. This uncovered errors with DPMS not turning the device off as it was left locked. Signed-off-by: Keith Packard --- drivers/gpu/drm/i915/intel_lvds.c | 13 +++-