Re: [PATCH 1/7] drm/arc: Stop consulting plane->fb

2018-04-06 Thread Alexey Brodkin
Hi Ville, On Thu, 2018-04-05 at 22:50 +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > We want to stop using plane->fb with atomic driver, so stop looking at > it. > > I have no idea what this code is trying to achieve. There is no > corresponding check in the enable path. Also since > arc

Re: [PATCH 1/7] drm/arc: Stop consulting plane->fb

2018-04-05 Thread Daniel Vetter
On Thu, Apr 05, 2018 at 11:19:44PM +0300, Ville Syrjälä wrote: > On Thu, Apr 05, 2018 at 10:08:57PM +0200, Daniel Vetter wrote: > > On Thu, Apr 05, 2018 at 10:50:29PM +0300, Ville Syrjala wrote: > > > From: Ville Syrjälä > > > > > > We want to stop using plane->fb with atomic driver, so stop look

Re: [PATCH 1/7] drm/arc: Stop consulting plane->fb

2018-04-05 Thread Ville Syrjälä
On Thu, Apr 05, 2018 at 10:08:57PM +0200, Daniel Vetter wrote: > On Thu, Apr 05, 2018 at 10:50:29PM +0300, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > We want to stop using plane->fb with atomic driver, so stop looking at > > it. > > > > I have no idea what this code is trying to achiev

Re: [PATCH 1/7] drm/arc: Stop consulting plane->fb

2018-04-05 Thread Daniel Vetter
On Thu, Apr 05, 2018 at 10:50:29PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > We want to stop using plane->fb with atomic driver, so stop looking at > it. > > I have no idea what this code is trying to achieve. There is no > corresponding check in the enable path. Also since > arc_pgu

[PATCH 1/7] drm/arc: Stop consulting plane->fb

2018-04-05 Thread Ville Syrjala
From: Ville Syrjälä We want to stop using plane->fb with atomic driver, so stop looking at it. I have no idea what this code is trying to achieve. There is no corresponding check in the enable path. Also since arc_pgu_set_pxl_fmt() will anyway oops if there is no fb I'm going to assuming that I