Re: [PATCH 10/10] drm/vkms: No need for ->pages_lock in crc work anymore

2019-06-12 Thread Rodrigo Siqueira
On Thu, Jun 6, 2019 at 7:28 PM Daniel Vetter wrote: > > We're now guaranteed to no longer race against prepare_fb/cleanup_fb, > which means we can access ->vaddr without having to hold a lock. > > Before the previous patches it was fairly easy to observe the cursor > ->vaddr being invalid, but tha

[PATCH 10/10] drm/vkms: No need for ->pages_lock in crc work anymore

2019-06-06 Thread Daniel Vetter
We're now guaranteed to no longer race against prepare_fb/cleanup_fb, which means we can access ->vaddr without having to hold a lock. Before the previous patches it was fairly easy to observe the cursor ->vaddr being invalid, but that's now gone, so we can upgrade to a full WARN_ON. Signed-off-b