Re: [PATCH 13/16] drm/fb-helper: Avoid race with DRM userspace

2019-04-01 Thread Noralf Trønnes
Den 01.04.2019 09.12, skrev Daniel Vetter: > On Sat, Mar 30, 2019 at 10:07:58PM +0100, Noralf Trønnes wrote: >> >> >> Den 28.03.2019 09.17, skrev Daniel Vetter: >>> On Tue, Mar 26, 2019 at 06:55:43PM +0100, Noralf Trønnes wrote: drm_fb_helper_is_bound() is used to check if DRM userspace is

Re: [PATCH 13/16] drm/fb-helper: Avoid race with DRM userspace

2019-04-01 Thread Daniel Vetter
On Sat, Mar 30, 2019 at 10:07:58PM +0100, Noralf Trønnes wrote: > > > Den 28.03.2019 09.17, skrev Daniel Vetter: > > On Tue, Mar 26, 2019 at 06:55:43PM +0100, Noralf Trønnes wrote: > >> drm_fb_helper_is_bound() is used to check if DRM userspace is in control. > >> This is done by looking at the

Re: [PATCH 13/16] drm/fb-helper: Avoid race with DRM userspace

2019-03-30 Thread Noralf Trønnes
Den 28.03.2019 09.17, skrev Daniel Vetter: > On Tue, Mar 26, 2019 at 06:55:43PM +0100, Noralf Trønnes wrote: >> drm_fb_helper_is_bound() is used to check if DRM userspace is in control. >> This is done by looking at the fb on the primary plane. By the time >> fb-helper gets around to committing,

Re: [PATCH 13/16] drm/fb-helper: Avoid race with DRM userspace

2019-03-28 Thread Daniel Vetter
On Tue, Mar 26, 2019 at 06:55:43PM +0100, Noralf Trønnes wrote: > drm_fb_helper_is_bound() is used to check if DRM userspace is in control. > This is done by looking at the fb on the primary plane. By the time > fb-helper gets around to committing, it's possible that the facts have > changed. > >

[PATCH 13/16] drm/fb-helper: Avoid race with DRM userspace

2019-03-26 Thread Noralf Trønnes
drm_fb_helper_is_bound() is used to check if DRM userspace is in control. This is done by looking at the fb on the primary plane. By the time fb-helper gets around to committing, it's possible that the facts have changed. Avoid this race by holding the drm_device->master_mutex lock while