Re: [PATCH 18/20] drm/i915: YCBCR 420 support for LSPCON

2017-07-13 Thread Sharma, Shashank
On 7/13/2017 6:43 PM, Ville Syrjälä wrote: We don't use those clocks with DP. You've just added them here because the function call requires them as parameters. Also the function call is actually doing the wrong thing for DP by halving port_clock. Ah, missed that part. Thanks for letting me

Re: [PATCH 18/20] drm/i915: YCBCR 420 support for LSPCON

2017-07-13 Thread Ville Syrjälä
On Thu, Jul 13, 2017 at 10:32:00AM +0530, Sharma, Shashank wrote: > Regards > > Shashank > > > On 7/12/2017 10:45 PM, Ville Syrjälä wrote: > > On Mon, Jul 10, 2017 at 04:48:46PM +0530, Shashank Sharma wrote: > >> LSPCON chips support YCBCR420 outputs. To be able to get > >> YCBCR420 output from

Re: [PATCH 18/20] drm/i915: YCBCR 420 support for LSPCON

2017-07-12 Thread Sharma, Shashank
Regards Shashank On 7/12/2017 10:45 PM, Ville Syrjälä wrote: On Mon, Jul 10, 2017 at 04:48:46PM +0530, Shashank Sharma wrote: LSPCON chips support YCBCR420 outputs. To be able to get YCBCR420 output from LSPCON chip, the source should: - Generate YCBCR444 HDMI output - Set AVI infoframes for

Re: [PATCH 18/20] drm/i915: YCBCR 420 support for LSPCON

2017-07-12 Thread Ville Syrjälä
On Mon, Jul 10, 2017 at 04:48:46PM +0530, Shashank Sharma wrote: > LSPCON chips support YCBCR420 outputs. To be able to get > YCBCR420 output from LSPCON chip, the source should: > - Generate YCBCR444 HDMI output > - Set AVI infoframes for a YCBCR420 output. > > LSPCON FW gets the information

[PATCH 18/20] drm/i915: YCBCR 420 support for LSPCON

2017-07-10 Thread Shashank Sharma
LSPCON chips support YCBCR420 outputs. To be able to get YCBCR420 output from LSPCON chip, the source should: - Generate YCBCR444 HDMI output - Set AVI infoframes for a YCBCR420 output. LSPCON FW gets the information from AVI infoframes, and generates YCBCR420 output from a YCBCR444 input. This