Re: [PATCH 18/21] fbcon: untangle fbcon_exit

2022-02-08 Thread Sam Ravnborg
On Tue, Feb 08, 2022 at 02:58:21PM +0100, Daniel Vetter wrote: > On Fri, Feb 04, 2022 at 09:06:38PM +0100, Sam Ravnborg wrote: > > Hi Daniel, > > > > On Mon, Jan 31, 2022 at 10:05:49PM +0100, Daniel Vetter wrote: > > > There's a bunch of confusions going on here: > > > - The deferred fbcon setup

Re: [PATCH 18/21] fbcon: untangle fbcon_exit

2022-02-08 Thread Daniel Vetter
On Fri, Feb 04, 2022 at 09:06:38PM +0100, Sam Ravnborg wrote: > Hi Daniel, > > On Mon, Jan 31, 2022 at 10:05:49PM +0100, Daniel Vetter wrote: > > There's a bunch of confusions going on here: > > - The deferred fbcon setup notifier should only be cleaned up from > > fb_console_exit(), to be

Re: [PATCH 18/21] fbcon: untangle fbcon_exit

2022-02-04 Thread Sam Ravnborg
Hi Daniel, On Mon, Jan 31, 2022 at 10:05:49PM +0100, Daniel Vetter wrote: > There's a bunch of confusions going on here: > - The deferred fbcon setup notifier should only be cleaned up from > fb_console_exit(), to be symmetric with fb_console_init() > - We also need to make sure we don't race

[PATCH 18/21] fbcon: untangle fbcon_exit

2022-01-31 Thread Daniel Vetter
There's a bunch of confusions going on here: - The deferred fbcon setup notifier should only be cleaned up from fb_console_exit(), to be symmetric with fb_console_init() - We also need to make sure we don't race with the work, which means temporarily dropping the console lock (or we can