Re: [PATCH 19/21] fbcon: Maintain a private array of fb_info

2022-02-08 Thread Sam Ravnborg
Hi Daniel, On Tue, Feb 08, 2022 at 03:03:28PM +0100, Daniel Vetter wrote: > On Fri, Feb 04, 2022 at 09:15:40PM +0100, Sam Ravnborg wrote: > > Hi Daniel, > > > > On Mon, Jan 31, 2022 at 10:05:50PM +0100, Daniel Vetter wrote: > > > Accessing the one in fbmem.c without taking the right locks is a

Re: [PATCH 19/21] fbcon: Maintain a private array of fb_info

2022-02-08 Thread Daniel Vetter
On Fri, Feb 04, 2022 at 09:15:40PM +0100, Sam Ravnborg wrote: > Hi Daniel, > > On Mon, Jan 31, 2022 at 10:05:50PM +0100, Daniel Vetter wrote: > > Accessing the one in fbmem.c without taking the right locks is a bad > > idea. Instead maintain our own private copy, which is fully protected > > by

Re: [PATCH 19/21] fbcon: Maintain a private array of fb_info

2022-02-04 Thread Sam Ravnborg
Hi Daniel, On Mon, Jan 31, 2022 at 10:05:50PM +0100, Daniel Vetter wrote: > Accessing the one in fbmem.c without taking the right locks is a bad > idea. Instead maintain our own private copy, which is fully protected > by console_lock() (like everything else in fbcon.c). That copy is > serialized

[PATCH 19/21] fbcon: Maintain a private array of fb_info

2022-01-31 Thread Daniel Vetter
Accessing the one in fbmem.c without taking the right locks is a bad idea. Instead maintain our own private copy, which is fully protected by console_lock() (like everything else in fbcon.c). That copy is serialized through fbcon_fb_registered/unregistered() calls. Also this means we do not need