Re: [PATCH 2/2] drm/fb-helper: Add a FIXME that generic_setup is very confusing

2020-12-23 Thread Maxime Ripard
On Tue, Dec 22, 2020 at 09:55:28AM +0100, Daniel Vetter wrote: > On Fri, Dec 11, 2020 at 05:11:13PM +0100, Daniel Vetter wrote: > > I tried to fix this for real, but it's very sprawling and lots of > > drivers get this mildly wrong one way or the other. > > > > Signed-off-by: Daniel Vetter > >

Re: [PATCH 2/2] drm/fb-helper: Add a FIXME that generic_setup is very confusing

2020-12-22 Thread Daniel Vetter
On Tue, Dec 22, 2020 at 09:00:43AM +, Simon Ser wrote: > On Tuesday, December 22nd, 2020 at 9:55 AM, Daniel Vetter > wrote: > > > On Fri, Dec 11, 2020 at 05:11:13PM +0100, Daniel Vetter wrote: > > > I tried to fix this for real, but it's very sprawling and lots of > > > drivers get this

Re: [PATCH 2/2] drm/fb-helper: Add a FIXME that generic_setup is very confusing

2020-12-22 Thread Simon Ser
On Tuesday, December 22nd, 2020 at 9:55 AM, Daniel Vetter wrote: > On Fri, Dec 11, 2020 at 05:11:13PM +0100, Daniel Vetter wrote: > > I tried to fix this for real, but it's very sprawling and lots of > > drivers get this mildly wrong one way or the other. > > > > Signed-off-by: Daniel Vetter >

Re: [PATCH 2/2] drm/fb-helper: Add a FIXME that generic_setup is very confusing

2020-12-22 Thread Daniel Vetter
On Fri, Dec 11, 2020 at 05:11:13PM +0100, Daniel Vetter wrote: > I tried to fix this for real, but it's very sprawling and lots of > drivers get this mildly wrong one way or the other. > > Signed-off-by: Daniel Vetter > Cc: Maarten Lankhorst > Cc: Maxime Ripard > Cc: Thomas Zimmermann > Cc:

[PATCH 2/2] drm/fb-helper: Add a FIXME that generic_setup is very confusing

2020-12-11 Thread Daniel Vetter
I tried to fix this for real, but it's very sprawling and lots of drivers get this mildly wrong one way or the other. Signed-off-by: Daniel Vetter Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann Cc: David Airlie Cc: Daniel Vetter --- drivers/gpu/drm/drm_fb_helper.c | 5 +