Re: [PATCH 2/2] drm/vkms: Use a simpler composition function

2024-02-15 Thread Arthur Grillo
On 08/02/24 06:39, Pekka Paalanen wrote: > On Wed, 7 Feb 2024 16:49:56 +0100 > Louis Chauvet wrote: > >> Hello Pekka, Arthur, Maxime, > > Hi all > >>> Change the composition algorithm to iterate over pixels instead of >>> lines. >>> It allows a simpler management of

Re: [PATCH 2/2] drm/vkms: Use a simpler composition function

2024-02-08 Thread Pekka Paalanen
On Wed, 7 Feb 2024 16:49:56 +0100 Louis Chauvet wrote: > Hello Pekka, Arthur, Maxime, Hi all > > > > >> Change the composition algorithm to iterate over pixels instead > > > > >> of lines. > > > > >> It allows a simpler management of rotation and pixel access for > > > > >>

Re: [PATCH 2/2] drm/vkms: Use a simpler composition function

2024-02-07 Thread Arthur Grillo
On 07/02/24 13:03, Louis Chauvet wrote: > Hello Pekka, Arthur, > > [...] > Would it be possible to have a standardised benchmark specifically for performance rather than correctness, in IGT or where-ever it would make sense? Then it would be simple to tell contributors to

Re: [PATCH 2/2] drm/vkms: Use a simpler composition function

2024-02-07 Thread Louis Chauvet
Hello Pekka, Arthur, [...] > > > Would it be possible to have a standardised benchmark specifically > > > for performance rather than correctness, in IGT or where-ever it > > > would make sense? Then it would be simple to tell contributors to > > > run this and report the numbers before and

Re: [PATCH 2/2] drm/vkms: Use a simpler composition function

2024-02-07 Thread Louis Chauvet
Hello Pekka, Arthur, Maxime, > > > >> Change the composition algorithm to iterate over pixels instead of > > > >> lines. > > > >> It allows a simpler management of rotation and pixel access for > > > >> complex formats. > > > >> > > > >> This new algorithm allows

Re: [PATCH 2/2] drm/vkms: Use a simpler composition function

2024-02-07 Thread Pekka Paalanen
On Tue, 6 Feb 2024 14:57:48 -0300 Arthur Grillo wrote: > On 02/02/24 16:45, Pekka Paalanen wrote: ... > > Would it be possible to have a standardised benchmark specifically > > for performance rather than correctness, in IGT or where-ever it > > would make sense? Then it would be simple to

Re: [PATCH 2/2] drm/vkms: Use a simpler composition function

2024-02-06 Thread Arthur Grillo
On 02/02/24 16:45, Pekka Paalanen wrote: > On Fri, 2 Feb 2024 17:07:34 +0100 > Miquel Raynal wrote: > >> Hi Pekka, > > Hi Miquel, > > I'm happy to see no hard feelings below. I know I may be blunt at > times. > > Another thing coming to my mind is that I suppose there is no > agreed

Re: [PATCH 2/2] drm/vkms: Use a simpler composition function

2024-02-05 Thread Pekka Paalanen
On Mon, 5 Feb 2024 12:12:04 +0200 Pekka Paalanen wrote: > On Fri, 2 Feb 2024 17:02:20 -0300 > Arthur Grillo wrote: > > > On 02/02/24 12:49, Pekka Paalanen wrote: > > > On Fri, 2 Feb 2024 13:13:22 +0100 > > > Miquel Raynal wrote: > > > > > >> Hello Maxime, > > >> > > >> + Arthur > > >>

Re: [PATCH 2/2] drm/vkms: Use a simpler composition function

2024-02-05 Thread Pekka Paalanen
On Fri, 2 Feb 2024 17:02:20 -0300 Arthur Grillo wrote: > On 02/02/24 12:49, Pekka Paalanen wrote: > > On Fri, 2 Feb 2024 13:13:22 +0100 > > Miquel Raynal wrote: > > > >> Hello Maxime, > >> > >> + Arthur > >> > >> mrip...@kernel.org wrote on Fri, 2 Feb 2024 10:53:37 +0100: > >> > >>> Hi

Re: [PATCH 2/2] drm/vkms: Use a simpler composition function

2024-02-02 Thread Arthur Grillo
On 02/02/24 12:49, Pekka Paalanen wrote: > On Fri, 2 Feb 2024 13:13:22 +0100 > Miquel Raynal wrote: > >> Hello Maxime, >> >> + Arthur >> >> mrip...@kernel.org wrote on Fri, 2 Feb 2024 10:53:37 +0100: >> >>> Hi Miquel, >>> >>> On Fri, Feb 02, 2024 at 10:26:01AM +0100, Miquel Raynal wrote:

Re: [PATCH 2/2] drm/vkms: Use a simpler composition function

2024-02-02 Thread Pekka Paalanen
On Fri, 2 Feb 2024 17:07:34 +0100 Miquel Raynal wrote: > Hi Pekka, Hi Miquel, I'm happy to see no hard feelings below. I know I may be blunt at times. Another thing coming to my mind is that I suppose there is no agreed standard benchmark for VKMS performance, is there? I recall people

Re: [PATCH 2/2] drm/vkms: Use a simpler composition function

2024-02-02 Thread Miquel Raynal
Hi Pekka, pekka.paala...@haloniitty.fi wrote on Fri, 2 Feb 2024 17:49:13 +0200: > On Fri, 2 Feb 2024 13:13:22 +0100 > Miquel Raynal wrote: > > > Hello Maxime, > > > > + Arthur > > > > mrip...@kernel.org wrote on Fri, 2 Feb 2024 10:53:37 +0100: > > > > > Hi Miquel, > > > > > > On Fri, Feb

Re: [PATCH 2/2] drm/vkms: Use a simpler composition function

2024-02-02 Thread Pekka Paalanen
On Fri, 2 Feb 2024 13:13:22 +0100 Miquel Raynal wrote: > Hello Maxime, > > + Arthur > > mrip...@kernel.org wrote on Fri, 2 Feb 2024 10:53:37 +0100: > > > Hi Miquel, > > > > On Fri, Feb 02, 2024 at 10:26:01AM +0100, Miquel Raynal wrote: > > > pekka.paala...@haloniitty.fi wrote on Fri, 2 Feb

Re: [PATCH 2/2] drm/vkms: Use a simpler composition function

2024-02-02 Thread Miquel Raynal
Hello Maxime, + Arthur mrip...@kernel.org wrote on Fri, 2 Feb 2024 10:53:37 +0100: > Hi Miquel, > > On Fri, Feb 02, 2024 at 10:26:01AM +0100, Miquel Raynal wrote: > > pekka.paala...@haloniitty.fi wrote on Fri, 2 Feb 2024 10:55:22 +0200: > > > > > On Thu, 01 Feb 2024 18:31:32 +0100 > > >

Re: [PATCH 2/2] drm/vkms: Use a simpler composition function

2024-02-02 Thread Pekka Paalanen
On Fri, 2 Feb 2024 10:26:01 +0100 Miquel Raynal wrote: > Hi Pekka, > > pekka.paala...@haloniitty.fi wrote on Fri, 2 Feb 2024 10:55:22 +0200: > > > On Thu, 01 Feb 2024 18:31:32 +0100 > > Louis Chauvet wrote: > > > > > Change the composition algorithm to iterate over pixels instead of lines.

Re: Re: [PATCH 2/2] drm/vkms: Use a simpler composition function

2024-02-02 Thread Maxime Ripard
Hi Miquel, On Fri, Feb 02, 2024 at 10:26:01AM +0100, Miquel Raynal wrote: > pekka.paala...@haloniitty.fi wrote on Fri, 2 Feb 2024 10:55:22 +0200: > > > On Thu, 01 Feb 2024 18:31:32 +0100 > > Louis Chauvet wrote: > > > > > Change the composition algorithm to iterate over pixels instead of

Re: [PATCH 2/2] drm/vkms: Use a simpler composition function

2024-02-02 Thread MaĆ­ra Canal
Hi Miquel, On 2/2/24 06:26, Miquel Raynal wrote: Hi Pekka, pekka.paala...@haloniitty.fi wrote on Fri, 2 Feb 2024 10:55:22 +0200: On Thu, 01 Feb 2024 18:31:32 +0100 Louis Chauvet wrote: Change the composition algorithm to iterate over pixels instead of lines. It allows a simpler management

Re: [PATCH 2/2] drm/vkms: Use a simpler composition function

2024-02-02 Thread Miquel Raynal
Hi Pekka, pekka.paala...@haloniitty.fi wrote on Fri, 2 Feb 2024 10:55:22 +0200: > On Thu, 01 Feb 2024 18:31:32 +0100 > Louis Chauvet wrote: > > > Change the composition algorithm to iterate over pixels instead of lines. > > It allows a simpler management of rotation and pixel access for

Re: [PATCH 2/2] drm/vkms: Use a simpler composition function

2024-02-02 Thread Pekka Paalanen
On Thu, 01 Feb 2024 18:31:32 +0100 Louis Chauvet wrote: > Change the composition algorithm to iterate over pixels instead of lines. > It allows a simpler management of rotation and pixel access for complex > formats. > > This new algorithm allows read_pixel function to have access to x/y >

[PATCH 2/2] drm/vkms: Use a simpler composition function

2024-02-01 Thread Louis Chauvet
Change the composition algorithm to iterate over pixels instead of lines. It allows a simpler management of rotation and pixel access for complex formats. This new algorithm allows read_pixel function to have access to x/y coordinates and make it possible to read the correct thing in a block when