Re: [PATCH 2/2] drm: Add ASPEED GFX driver

2019-04-01 Thread Joel Stanley
On Thu, 28 Mar 2019 at 07:53, Daniel Vetter wrote: > > +static int aspeed_gfx_get_modes(struct drm_connector *connector) > > +{ > > + return drm_add_modes_noedid(connector, 800, 600); > > Is this the only mode you do, or just a default? Iirc if you report > "connected", you'll get this as

Re: [PATCH 2/2] drm: Add ASPEED GFX driver

2019-04-01 Thread Sam Ravnborg
Hi Joel. Replying to Noralf's mail as I lost the original mail. > > diff --git a/drivers/gpu/drm/aspeed/aspeed_gfx_crtc.c > > b/drivers/gpu/drm/aspeed/aspeed_gfx_crtc.c > > new file mode 100644 > > index ..e2d1d7497352 > > --- /dev/null > > +++

Re: [PATCH 2/2] drm: Add ASPEED GFX driver

2019-04-01 Thread Noralf Trønnes
Den 28.03.2019 06.43, skrev Joel Stanley: > This driver is for the ASPEED BMC SoC's GFX display hardware. This > driver runs on the ARM based BMC systems, unlike the ast driver which > runs on a host CPU and is is for a PCI graphics device. > > Signed-off-by: Joel Stanley > -- > Changes since

Re: [PATCH 2/2] drm: Add ASPEED GFX driver

2019-03-28 Thread Daniel Vetter
On Thu, Mar 28, 2019 at 04:13:16PM +1030, Joel Stanley wrote: > This driver is for the ASPEED BMC SoC's GFX display hardware. This > driver runs on the ARM based BMC systems, unlike the ast driver which > runs on a host CPU and is is for a PCI graphics device. > > Signed-off-by: Joel Stanley >

[PATCH 2/2] drm: Add ASPEED GFX driver

2019-03-27 Thread Joel Stanley
This driver is for the ASPEED BMC SoC's GFX display hardware. This driver runs on the ARM based BMC systems, unlike the ast driver which runs on a host CPU and is is for a PCI graphics device. Signed-off-by: Joel Stanley -- Changes since RFC: drm_fbdev_cma_init -> drm_fb_cma_fbdev_init and use