Re: [PATCH 2/2] fbdev: Don't sort deferred-I/O pages by default

2022-02-14 Thread Thomas Zimmermann
Hi Am 14.02.22 um 10:05 schrieb Geert Uytterhoeven: Hi Thomas, On Mon, Feb 14, 2022 at 9:28 AM Thomas Zimmermann wrote: Am 14.02.22 um 09:05 schrieb Geert Uytterhoeven: On Thu, Feb 10, 2022 at 4:24 PM Thomas Zimmermann wrote: Fbdev's deferred I/O sorts all dirty pages by default, which

Re: [PATCH 2/2] fbdev: Don't sort deferred-I/O pages by default

2022-02-14 Thread Geert Uytterhoeven
Hi Thomas, On Mon, Feb 14, 2022 at 9:28 AM Thomas Zimmermann wrote: > Am 14.02.22 um 09:05 schrieb Geert Uytterhoeven: > > On Thu, Feb 10, 2022 at 4:24 PM Thomas Zimmermann > > wrote: > >> Fbdev's deferred I/O sorts all dirty pages by default, which incurs a > >> significant overhead. Make the

Re: [PATCH 2/2] fbdev: Don't sort deferred-I/O pages by default

2022-02-14 Thread Thomas Zimmermann
Hi Am 14.02.22 um 09:05 schrieb Geert Uytterhoeven: Hi Thomas, On Thu, Feb 10, 2022 at 4:24 PM Thomas Zimmermann wrote: Fbdev's deferred I/O sorts all dirty pages by default, which incurs a significant overhead. Make the sorting step optional and update the few drivers that require it. Use a

Re: [PATCH 2/2] fbdev: Don't sort deferred-I/O pages by default

2022-02-14 Thread Geert Uytterhoeven
Hi Thomas, On Thu, Feb 10, 2022 at 4:24 PM Thomas Zimmermann wrote: > Fbdev's deferred I/O sorts all dirty pages by default, which incurs a > significant overhead. Make the sorting step optional and update the few > drivers that require it. Use a FIFO list by default. > > Sorting pages by memory

Re: [PATCH 2/2] fbdev: Don't sort deferred-I/O pages by default

2022-02-11 Thread Thomas Zimmermann
Hi Am 11.02.22 um 08:58 schrieb Dan Carpenter: On Thu, Feb 10, 2022 at 10:16:45PM +0100, Sam Ravnborg wrote: diff --git a/drivers/video/fbdev/core/fb_defio.c b/drivers/video/fbdev/core/fb_defio.c index 3727b1ca87b1..1f672cf253b2 100644 --- a/drivers/video/fbdev/core/fb_defio.c +++

Re: [PATCH 2/2] fbdev: Don't sort deferred-I/O pages by default

2022-02-11 Thread Thomas Zimmermann
Hi Sam Am 10.02.22 um 22:16 schrieb Sam Ravnborg: Hi Thomas, On Thu, Feb 10, 2022 at 03:11:13PM +0100, Thomas Zimmermann wrote: Fbdev's deferred I/O sorts all dirty pages by default, which incurs a significant overhead. Make the sorting step optional and update the few drivers that require

Re: [PATCH 2/2] fbdev: Don't sort deferred-I/O pages by default

2022-02-10 Thread Dan Carpenter
On Thu, Feb 10, 2022 at 10:16:45PM +0100, Sam Ravnborg wrote: > > diff --git a/drivers/video/fbdev/core/fb_defio.c > > b/drivers/video/fbdev/core/fb_defio.c > > index 3727b1ca87b1..1f672cf253b2 100644 > > --- a/drivers/video/fbdev/core/fb_defio.c > > +++ b/drivers/video/fbdev/core/fb_defio.c > >

Re: [PATCH 2/2] fbdev: Don't sort deferred-I/O pages by default

2022-02-10 Thread Sam Ravnborg
Hi Thomas, On Thu, Feb 10, 2022 at 03:11:13PM +0100, Thomas Zimmermann wrote: > Fbdev's deferred I/O sorts all dirty pages by default, which incurs a > significant overhead. Make the sorting step optional and update the few > drivers that require it. Use a FIFO list by default. > > Sorting pages

Re: [PATCH 2/2] fbdev: Don't sort deferred-I/O pages by default

2022-02-10 Thread Andy Shevchenko
On Thu, Feb 10, 2022 at 03:11:13PM +0100, Thomas Zimmermann wrote: > Fbdev's deferred I/O sorts all dirty pages by default, which incurs a > significant overhead. Make the sorting step optional and update the few > drivers that require it. Use a FIFO list by default. > > Sorting pages by memory

[PATCH 2/2] fbdev: Don't sort deferred-I/O pages by default

2022-02-10 Thread Thomas Zimmermann
Fbdev's deferred I/O sorts all dirty pages by default, which incurs a significant overhead. Make the sorting step optional and update the few drivers that require it. Use a FIFO list by default. Sorting pages by memory offset for deferred I/O performs an implicit bubble-sort step on the list of