Re: [PATCH 2/3] drm/panel: panel-dsi-cm: Use backlight helpers

2022-06-10 Thread Stephen Kitt
On Fri, 10 Jun 2022 21:52:36 +0200, Stephen Kitt wrote: > On Fri, 10 Jun 2022 21:28:32 +0200, Sam Ravnborg wrote: > > Hi Stephen. > > On Fri, Jun 10, 2022 at 07:47:20PM +0200, Stephen Kitt wrote: > > > Hi Sebastian, > > > > > > On Thu, 9 Jun 2022 23:52:36 +0200, Sebastian Reichel > > >

Re: [PATCH 2/3] drm/panel: panel-dsi-cm: Use backlight helpers

2022-06-10 Thread Stephen Kitt
On Fri, 10 Jun 2022 21:28:32 +0200, Sam Ravnborg wrote: > Hi Stephen. > On Fri, Jun 10, 2022 at 07:47:20PM +0200, Stephen Kitt wrote: > > Hi Sebastian, > > > > On Thu, 9 Jun 2022 23:52:36 +0200, Sebastian Reichel > > wrote: > > > On Tue, Jun 07, 2022 at 08:20:25PM +0200, Stephen Kitt wrote:

Re: [PATCH 2/3] drm/panel: panel-dsi-cm: Use backlight helpers

2022-06-10 Thread Sam Ravnborg
Hi Stephen, > > > > > > > > Thanks, I’ll wait a little more to see if there are any other reviews of > > > > the patches and then push a v2 with that fix. > > > It would be very nice if you could kill all uses of FB_BLANK in the > > > drivers/gpu/drm/panel/* drivers, and post them as one

Re: [PATCH 2/3] drm/panel: panel-dsi-cm: Use backlight helpers

2022-06-10 Thread Sam Ravnborg
Hi Stephen. On Fri, Jun 10, 2022 at 07:47:20PM +0200, Stephen Kitt wrote: > Hi Sebastian, > > On Thu, 9 Jun 2022 23:52:36 +0200, Sebastian Reichel > wrote: > > On Tue, Jun 07, 2022 at 08:20:25PM +0200, Stephen Kitt wrote: > > > diff --git a/drivers/gpu/drm/panel/panel-dsi-cm.c > > >

Re: [PATCH 2/3] drm/panel: panel-dsi-cm: Use backlight helpers

2022-06-10 Thread Stephen Kitt
Hi Sebastian, On Thu, 9 Jun 2022 23:52:36 +0200, Sebastian Reichel wrote: > On Tue, Jun 07, 2022 at 08:20:25PM +0200, Stephen Kitt wrote: > > diff --git a/drivers/gpu/drm/panel/panel-dsi-cm.c > > b/drivers/gpu/drm/panel/panel-dsi-cm.c index b58cb064975f..aa36dc6cedd3 > > 100644 ---

Re: [PATCH 2/3] drm/panel: panel-dsi-cm: Use backlight helpers

2022-06-09 Thread Sebastian Reichel
Hi, On Tue, Jun 07, 2022 at 08:20:25PM +0200, Stephen Kitt wrote: > Instead of retrieving the backlight brightness in struct > backlight_properties manually, and then checking whether the backlight > should be on at all, use backlight_get_brightness() which does all > this and insulates this from

[PATCH 2/3] drm/panel: panel-dsi-cm: Use backlight helpers

2022-06-07 Thread Stephen Kitt
Instead of retrieving the backlight brightness in struct backlight_properties manually, and then checking whether the backlight should be on at all, use backlight_get_brightness() which does all this and insulates this from future changes. Instead of setting the power state by manually updating