[PATCH 2/3] drm: add CRTC properties

2012-01-17 Thread Daniel Vetter
On Mon, Jan 16, 2012 at 06:29:36PM -0200, Paulo Zanoni wrote: > Three comments about the design are inline: > > > +void drm_crtc_attach_property(struct drm_crtc *crtc, > > + ? ? ? ? ? ? ? ? ? ? ? ? ? ? struct drm_property *property, uint64_t > > init_val) > > +{ > > + ? ? ? int i; > > + > > + ?

Re: [PATCH 2/3] drm: add CRTC properties

2012-01-17 Thread Daniel Vetter
On Mon, Jan 16, 2012 at 06:29:36PM -0200, Paulo Zanoni wrote: Three comments about the design are inline: +void drm_crtc_attach_property(struct drm_crtc *crtc, +                             struct drm_property *property, uint64_t init_val) +{ +       int i; + +       for (i = 0;

[PATCH 2/3] drm: add CRTC properties

2012-01-16 Thread Paulo Zanoni
Three comments about the design are inline: > +void drm_crtc_attach_property(struct drm_crtc *crtc, > + ? ? ? ? ? ? ? ? ? ? ? ? ? ? struct drm_property *property, uint64_t > init_val) > +{ > + ? ? ? int i; > + > + ? ? ? for (i = 0; i < DRM_CRTC_MAX_PROPERTY; i++) { > + ? ? ? ? ? ? ? if

[PATCH 2/3] drm: add CRTC properties

2012-01-16 Thread Paulo Zanoni
From: Paulo Zanoni Code based on the connector properties code. Two new ioctls: - DRM_IOCTL_MODE_CRTC_GETPROPERTIES - DRM_IOCTL_MODE_CRTC_SETPROPERTY The i915 driver needs this (for the rotation property). Other drivers might need this too. Signed-off-by: Paulo

[PATCH 2/3] drm: add CRTC properties

2012-01-16 Thread Paulo Zanoni
From: Paulo Zanoni paulo.r.zan...@intel.com Code based on the connector properties code. Two new ioctls: - DRM_IOCTL_MODE_CRTC_GETPROPERTIES - DRM_IOCTL_MODE_CRTC_SETPROPERTY The i915 driver needs this (for the rotation property). Other drivers might need this too. Signed-off-by: Paulo Zanoni

Re: [PATCH 2/3] drm: add CRTC properties

2012-01-16 Thread Paulo Zanoni
Three comments about the design are inline: +void drm_crtc_attach_property(struct drm_crtc *crtc, +                             struct drm_property *property, uint64_t init_val) +{ +       int i; + +       for (i = 0; i DRM_CRTC_MAX_PROPERTY; i++) { +               if