Re: [PATCH 23/30] fbdev/tdfxfb: Set i2c adapter parent to hardware device

[Javier Martinez Canillas]

Thomas Zimmermann  writes:

> Use the 3dfx hardware device from the Linux device hierarchy as
> parent device of the i2c adapter. Aligns the driver with the rest
> of the codebase and prepares fbdev for making struct fb_info.dev
> optional.
>
> Signed-off-by: Thomas Zimmermann 
> ---

Reviewed-by: Javier Martinez Canillas 

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat

[PATCH 23/30] fbdev/tdfxfb: Set i2c adapter parent to hardware device

[Thomas Zimmermann]

Use the 3dfx hardware device from the Linux device hierarchy as
parent device of the i2c adapter. Aligns the driver with the rest
of the codebase and prepares fbdev for making struct fb_info.dev
optional.

Signed-off-by: Thomas Zimmermann 
---
 drivers/video/fbdev/tdfxfb.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/video/fbdev/tdfxfb.c b/drivers/video/fbdev/tdfxfb.c
index cdf8e9fe9948..dd0fa42eceb9 100644
--- a/drivers/video/fbdev/tdfxfb.c
+++ b/drivers/video/fbdev/tdfxfb.c
@@ -1327,8 +1327,8 @@ static void tdfxfb_create_i2c_busses(struct fb_info *info)
par->chan[0].par = par;
par->chan[1].par = par;
 
-   tdfxfb_setup_ddc_bus(>chan[0], "Voodoo3-DDC", info->dev);
-   tdfxfb_setup_i2c_bus(>chan[1], "Voodoo3-I2C", info->dev);
+   tdfxfb_setup_ddc_bus(>chan[0], "Voodoo3-DDC", info->device);
+   tdfxfb_setup_i2c_bus(>chan[1], "Voodoo3-I2C", info->device);
 }
 
 static void tdfxfb_delete_i2c_busses(struct tdfx_par *par)
-- 
2.40.1