Re: [PATCH 24/60] drm/panel: Add driver for the Toppology TD043MTEA1 panel

2019-08-09 Thread Laurent Pinchart
Hi Sam, On Fri, Aug 09, 2019 at 03:33:08PM +0200, Sam Ravnborg wrote: > Hi Laurent. > > > > > +static int td043mtea1_disable(struct drm_panel *panel) > > > > +{ > > > > + struct td043mtea1_device *lcd = to_td043mtea1_device(panel); > > > > + > > > > + if (!lcd->spi_suspended) > > > >

Re: [PATCH 24/60] drm/panel: Add driver for the Toppology TD043MTEA1 panel

2019-08-09 Thread Sam Ravnborg
Hi Laurent. > > > +static int td043mtea1_disable(struct drm_panel *panel) > > > +{ > > > + struct td043mtea1_device *lcd = to_td043mtea1_device(panel); > > > + > > > + if (!lcd->spi_suspended) > > > + td043mtea1_power_off(lcd); > > > + > > > + return 0; > > > +} > > > + > > > +static int

Re: [PATCH 24/60] drm/panel: Add driver for the Toppology TD043MTEA1 panel

2019-08-08 Thread Laurent Pinchart
Hi Sam, On Wed, Jul 10, 2019 at 03:09:17PM +0200, Sam Ravnborg wrote: > Hi Laurent. > > I had assumed this driver would look like the other Topology driver, but > they differ a lot. So it makes sense to have different drivers. > > This driver implements suspend/resume. > But the correct way

Re: [PATCH 24/60] drm/panel: Add driver for the Toppology TD043MTEA1 panel

2019-07-10 Thread Sam Ravnborg
Hi Laurent. I had assumed this driver would look like the other Topology driver, but they differ a lot. So it makes sense to have different drivers. This driver implements suspend/resume. But the correct way would be to implment prepare/unprepare. The power_on(), power_off() functions would