Re: [PATCH 3/3] ANDROID: goldfish_fb: Set pixclock = 0

[Roman Kiryanov]

Hi,

thank you for reviewing our patches. I sent "v2".

Regards,
Roman.
On Fri, Jun 8, 2018 at 9:24 AM Bartlomiej Zolnierkiewicz
 wrote:
>
>
> [ + linux-fbdev ML ]
>
> On Thursday, May 31, 2018 03:02:52 PM r...@google.com wrote:
> > From: Christoffer Dall 
> >
> > User space Android code identifies pixclock == 0 as a sign for emulation
> > and will set the frame rate to 60 fps when reading this value, which is
> > the desired outcome.
> >
> > Change-Id: I759bf518bf6683446bc786bf1be3cafa02dd8d42
>
> please drop your local Change-Id from the upstream kernel submissions
>
> > Signed-off-by: Christoffer Dall 
> > Signed-off-by: Peter Maydell 
>
> your S-o-b line is also needed
>
> Best regards,
> --
> Bartlomiej Zolnierkiewicz
> Samsung R Institute Poland
> Samsung Electronics
>
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 3/3] ANDROID: goldfish_fb: Set pixclock = 0

[Bartlomiej Zolnierkiewicz]

[ + linux-fbdev ML ]

On Thursday, May 31, 2018 03:02:52 PM r...@google.com wrote:
> From: Christoffer Dall 
> 
> User space Android code identifies pixclock == 0 as a sign for emulation
> and will set the frame rate to 60 fps when reading this value, which is
> the desired outcome.
> 
> Change-Id: I759bf518bf6683446bc786bf1be3cafa02dd8d42

please drop your local Change-Id from the upstream kernel submissions

> Signed-off-by: Christoffer Dall 
> Signed-off-by: Peter Maydell 

your S-o-b line is also needed

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R Institute Poland
Samsung Electronics

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH 3/3] ANDROID: goldfish_fb: Set pixclock = 0

[rkir]

From: Christoffer Dall 

User space Android code identifies pixclock == 0 as a sign for emulation
and will set the frame rate to 60 fps when reading this value, which is
the desired outcome.

Change-Id: I759bf518bf6683446bc786bf1be3cafa02dd8d42
Signed-off-by: Christoffer Dall 
Signed-off-by: Peter Maydell 
---
 drivers/video/fbdev/goldfishfb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/video/fbdev/goldfishfb.c b/drivers/video/fbdev/goldfishfb.c
index 01732858b60d..3a9e5f1b758e 100644
--- a/drivers/video/fbdev/goldfishfb.c
+++ b/drivers/video/fbdev/goldfishfb.c
@@ -237,7 +237,7 @@ static int goldfish_fb_probe(struct platform_device *pdev)
fb->fb.var.activate = FB_ACTIVATE_NOW;
fb->fb.var.height   = readl(fb->reg_base + FB_GET_PHYS_HEIGHT);
fb->fb.var.width= readl(fb->reg_base + FB_GET_PHYS_WIDTH);
-   fb->fb.var.pixclock = 1;
+   fb->fb.var.pixclock = 0;
 
fb->fb.var.red.offset = 11;
fb->fb.var.red.length = 5;
-- 
2.17.0.921.gf22659ad46-goog

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel