Re: [PATCH 3/3] ARM: logicpd-torpedo-37xx-devkit-28: Reference new DRM panel

2019-09-23 Thread Adam Ford 
On Sat, Sep 21, 2019 at 2:09 PM Sam Ravnborg  wrote:
>
> Hi Adam.
>
> On Tue, Sep 17, 2019 at 11:12:13AM -0500, Adam Ford wrote:
> > With the removal of the panel-dpi from the omap drivers, the
> > LCD no longer works.  This patch points the device tree to
> > a newly created panel named "logicpd,type28"
> >
> > Fixes: 8bf4b1621178 ("drm/omap: Remove panel-dpi driver")
> >
> > Signed-off-by: Adam Ford 
> Looks good.
> One nit below.
>
> With this addressed:
>
> Acked-by: Sam Ravnborg 
>
> Sam
> >
> > diff --git a/arch/arm/boot/dts/logicpd-torpedo-37xx-devkit-28.dts 
> > b/arch/arm/boot/dts/logicpd-torpedo-37xx-devkit-28.dts
> > index 07ac99b9cda6..00c426bd51a0 100644
> > --- a/arch/arm/boot/dts/logicpd-torpedo-37xx-devkit-28.dts
> > +++ b/arch/arm/boot/dts/logicpd-torpedo-37xx-devkit-28.dts
> > @@ -11,22 +11,8 @@
> >  #include "logicpd-torpedo-37xx-devkit.dts"
> >
> >   {
> > -
> > + /* This isn't the exact LCD, but the timings meet spec */
> > + /* To make it work, set CONFIG_OMAP2_DSS_MIN_FCK_PER_PCK=4 */
> > + compatible = "logicpd,type28";
> >   label = "28";
> You left this property - but us it documented and what use has it?

Good catch, I'll remove it and post a V2 today once I can figure out
the yaml stuff.

adam
>
> > -
> > - panel-timing {
> > - clock-frequency = <900>;
> > - hactive = <480>;
> > - vactive = <272>;
> > - hfront-porch = <3>;
> > - hback-porch = <2>;
> > - hsync-len = <42>;
> > - vback-porch = <3>;
> > - vfront-porch = <2>;
> > - vsync-len = <11>;
> > - hsync-active = <1>;
> > - vsync-active = <1>;
> > - de-active = <1>;
> > - pixelclk-active = <0>;
> > - };
> >  };
> > --
> > 2.17.1
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 3/3] ARM: logicpd-torpedo-37xx-devkit-28: Reference new DRM panel

2019-09-21 Thread Sam Ravnborg 
Hi Adam.

On Tue, Sep 17, 2019 at 11:12:13AM -0500, Adam Ford wrote:
> With the removal of the panel-dpi from the omap drivers, the
> LCD no longer works.  This patch points the device tree to
> a newly created panel named "logicpd,type28"
> 
> Fixes: 8bf4b1621178 ("drm/omap: Remove panel-dpi driver")
> 
> Signed-off-by: Adam Ford 
Looks good.
One nit below.

With this addressed:

Acked-by: Sam Ravnborg 

Sam
> 
> diff --git a/arch/arm/boot/dts/logicpd-torpedo-37xx-devkit-28.dts 
> b/arch/arm/boot/dts/logicpd-torpedo-37xx-devkit-28.dts
> index 07ac99b9cda6..00c426bd51a0 100644
> --- a/arch/arm/boot/dts/logicpd-torpedo-37xx-devkit-28.dts
> +++ b/arch/arm/boot/dts/logicpd-torpedo-37xx-devkit-28.dts
> @@ -11,22 +11,8 @@
>  #include "logicpd-torpedo-37xx-devkit.dts"
>  
>   {
> -
> + /* This isn't the exact LCD, but the timings meet spec */
> + /* To make it work, set CONFIG_OMAP2_DSS_MIN_FCK_PER_PCK=4 */
> + compatible = "logicpd,type28";
>   label = "28";
You left this property - but us it documented and what use has it?

> -
> - panel-timing {
> - clock-frequency = <900>;
> - hactive = <480>;
> - vactive = <272>;
> - hfront-porch = <3>;
> - hback-porch = <2>;
> - hsync-len = <42>;
> - vback-porch = <3>;
> - vfront-porch = <2>;
> - vsync-len = <11>;
> - hsync-active = <1>;
> - vsync-active = <1>;
> - de-active = <1>;
> - pixelclk-active = <0>;
> - };
>  };
> -- 
> 2.17.1

[PATCH 3/3] ARM: logicpd-torpedo-37xx-devkit-28: Reference new DRM panel

2019-09-17 Thread Adam Ford 
With the removal of the panel-dpi from the omap drivers, the
LCD no longer works.  This patch points the device tree to
a newly created panel named "logicpd,type28"

Fixes: 8bf4b1621178 ("drm/omap: Remove panel-dpi driver")

Signed-off-by: Adam Ford 

diff --git a/arch/arm/boot/dts/logicpd-torpedo-37xx-devkit-28.dts 
b/arch/arm/boot/dts/logicpd-torpedo-37xx-devkit-28.dts
index 07ac99b9cda6..00c426bd51a0 100644
--- a/arch/arm/boot/dts/logicpd-torpedo-37xx-devkit-28.dts
+++ b/arch/arm/boot/dts/logicpd-torpedo-37xx-devkit-28.dts
@@ -11,22 +11,8 @@
 #include "logicpd-torpedo-37xx-devkit.dts"
 
  {
-
+   /* This isn't the exact LCD, but the timings meet spec */
+   /* To make it work, set CONFIG_OMAP2_DSS_MIN_FCK_PER_PCK=4 */
+   compatible = "logicpd,type28";
label = "28";
-
-   panel-timing {
-   clock-frequency = <900>;
-   hactive = <480>;
-   vactive = <272>;
-   hfront-porch = <3>;
-   hback-porch = <2>;
-   hsync-len = <42>;
-   vback-porch = <3>;
-   vfront-porch = <2>;
-   vsync-len = <11>;
-   hsync-active = <1>;
-   vsync-active = <1>;
-   de-active = <1>;
-   pixelclk-active = <0>;
-   };
 };
-- 
2.17.1

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel