Re: [PATCH 30/45] drm/ttm: add a new invalidate notify callback.

2020-09-29 Thread Christian König
Am 29.09.20 um 05:23 schrieb Dave Airlie: On Thu, 24 Sep 2020 at 22:25, Christian König wrote: Am 24.09.20 um 07:18 schrieb Dave Airlie: From: Dave Airlie Signed-off-by: Dave Airlie NAK, completely unnecessary. We should rather do the remaining accounting in the already existing

Re: [PATCH 30/45] drm/ttm: add a new invalidate notify callback.

2020-09-28 Thread Dave Airlie
On Thu, 24 Sep 2020 at 22:25, Christian König wrote: > > Am 24.09.20 um 07:18 schrieb Dave Airlie: > > From: Dave Airlie > > > > Signed-off-by: Dave Airlie > > NAK, completely unnecessary. > > We should rather do the remaining accounting in the already existing > release_notify() callback. > >

Re: [PATCH 30/45] drm/ttm: add a new invalidate notify callback.

2020-09-24 Thread Christian König
Am 24.09.20 um 07:18 schrieb Dave Airlie: From: Dave Airlie Signed-off-by: Dave Airlie NAK, completely unnecessary. We should rather do the remaining accounting in the already existing release_notify() callback. That makes much more sense and if I'm not completely mistaken could

Re: [PATCH 30/45] drm/ttm: add a new invalidate notify callback.

2020-09-24 Thread Daniel Vetter
On Thu, Sep 24, 2020 at 03:18:30PM +1000, Dave Airlie wrote: > From: Dave Airlie > > Signed-off-by: Dave Airlie A bikeshed, but why not just call this ->invalidate? ->move_notify needed the _notify because we already had the ->move callback, but there's not invalidate that also needs a

[PATCH 30/45] drm/ttm: add a new invalidate notify callback.

2020-09-23 Thread Dave Airlie
From: Dave Airlie Signed-off-by: Dave Airlie --- drivers/gpu/drm/ttm/ttm_bo.c| 4 +++- include/drm/ttm/ttm_bo_driver.h | 7 +++ 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c index a2a61a8d1394..ba69c682e53b