Re: [PATCH 4/4] drm/bridge: dw-hdmi: add cec driver

On 06/01/2017 10:31 AM, Hans Verkuil wrote: Hi Russell, First a few top-level questions: 1) What was the reason for using the cec-notifier here? Isn't this tightly integrated into the main dw-hdmi block? For the tda driver it is clearly required, but for tightly coupled HDMI & CEC HW I

Re: [PATCH 4/4] drm/bridge: dw-hdmi: add cec driver

On Fri, Jun 02, 2017 at 11:28:08AM +0200, Hans Verkuil wrote: > The 'signal_free_time' argument of adap_transmit will have the recommended > signal free time. You can test against the CEC_SIGNAL_FREE_TIME_* defines > from media/cec.h. You probably saw this already, but just in case you missed >

Re: [PATCH 4/4] drm/bridge: dw-hdmi: add cec driver

On Fri, Jun 02, 2017 at 06:02:28AM +0100, Jose Abreu wrote: > You should check that CEC is: not in standy, acknowledges > broadcast messages, signal free time is 5bit period, and not lost > arbitration, which basically means CEC_CTRL must be 0x2 and > IH_CEC_STAT0 must not have ARB_LOST set. If

Re: [PATCH 4/4] drm/bridge: dw-hdmi: add cec driver

On Thu, Jun 01, 2017 at 10:31:10AM +0200, Hans Verkuil wrote: > This will change. Patches to fix the config handling are pending for 4.12. > > Here you can see the pending patches: > https://git.linuxtv.org/hverkuil/media_tree.git/log/?h=drm-cec > > The patches from 'cec-notifier.h: handle

Re: [PATCH 4/4] drm/bridge: dw-hdmi: add cec driver

On Fri, Jun 02, 2017 at 11:06:24AM +0200, Hans Verkuil wrote: > On 06/02/17 08:43, Jose Abreu wrote: > > Hi Hans, > > > > > > On 02-06-2017 07:31, Hans Verkuil wrote: > >> On 06/01/2017 03:47 PM, Neil Armstrong wrote: > >>> On 05/30/2017 04:23 PM, Russell King wrote: > Add a CEC driver for

Re: [PATCH 4/4] drm/bridge: dw-hdmi: add cec driver

On 06/02/17 14:07, Russell King - ARM Linux wrote: > On Thu, Jun 01, 2017 at 10:31:10AM +0200, Hans Verkuil wrote: >> This will change. Patches to fix the config handling are pending for 4.12. >> >> Here you can see the pending patches: >>

Re: [PATCH 4/4] drm/bridge: dw-hdmi: add cec driver

On 06/02/17 11:15, Russell King - ARM Linux wrote: > On Fri, Jun 02, 2017 at 06:02:28AM +0100, Jose Abreu wrote: >> You should check that CEC is: not in standy, acknowledges >> broadcast messages, signal free time is 5bit period, and not lost >> arbitration, which basically means CEC_CTRL must be

Re: [PATCH 4/4] drm/bridge: dw-hdmi: add cec driver

On 06/02/17 08:43, Jose Abreu wrote: > Hi Hans, > > > On 02-06-2017 07:31, Hans Verkuil wrote: >> On 06/01/2017 03:47 PM, Neil Armstrong wrote: >>> On 05/30/2017 04:23 PM, Russell King wrote: Add a CEC driver for the dw-hdmi hardware. Signed-off-by: Russell King

Re: [PATCH 4/4] drm/bridge: dw-hdmi: add cec driver

Hi Hans, On 02-06-2017 07:31, Hans Verkuil wrote: > On 06/01/2017 03:47 PM, Neil Armstrong wrote: >> On 05/30/2017 04:23 PM, Russell King wrote: >>> Add a CEC driver for the dw-hdmi hardware. >>> >>> Signed-off-by: Russell King >>> --- >>>

Re: [PATCH 4/4] drm/bridge: dw-hdmi: add cec driver

On 01-06-2017 23:30, Russell King - ARM Linux wrote: > On Thu, Jun 01, 2017 at 01:53:21AM +0100, Jose Abreu wrote: >> Hi Russell, >> >> >> On 30-05-2017 15:23, Russell King wrote: >>> +static int dw_hdmi_cec_transmit(struct cec_adapter *adap, u8 attempts, >>> + u32

Re: [PATCH 4/4] drm/bridge: dw-hdmi: add cec driver

On 06/01/2017 03:47 PM, Neil Armstrong wrote: On 05/30/2017 04:23 PM, Russell King wrote: Add a CEC driver for the dw-hdmi hardware. Signed-off-by: Russell King --- drivers/gpu/drm/bridge/synopsys/Kconfig | 8 + drivers/gpu/drm/bridge/synopsys/Makefile

Re: [PATCH 4/4] drm/bridge: dw-hdmi: add cec driver

On Thu, Jun 01, 2017 at 10:31:10AM +0200, Hans Verkuil wrote: > Hi Russell, > > First a few top-level questions: Hi Hans, > 1) What was the reason for using the cec-notifier here? Isn't this >tightly integrated into the main dw-hdmi block? For the tda driver >it is clearly required, but

Re: [PATCH 4/4] drm/bridge: dw-hdmi: add cec driver

On Thu, Jun 01, 2017 at 01:53:21AM +0100, Jose Abreu wrote: > Hi Russell, > > > On 30-05-2017 15:23, Russell King wrote: > > +static int dw_hdmi_cec_transmit(struct cec_adapter *adap, u8 attempts, > > + u32 signal_free_time, struct cec_msg *msg) > > +{ > > + struct

Re: [PATCH 4/4] drm/bridge: dw-hdmi: add cec driver

Hi Russell, On 30-05-2017 15:23, Russell King wrote: > Add a CEC driver for the dw-hdmi hardware. > > Signed-off-by: Russell King > --- > drivers/gpu/drm/bridge/synopsys/Kconfig | 8 + > drivers/gpu/drm/bridge/synopsys/Makefile | 1 + >

Re: [PATCH 4/4] drm/bridge: dw-hdmi: add cec driver

On 05/30/2017 04:23 PM, Russell King wrote: > Add a CEC driver for the dw-hdmi hardware. > > Signed-off-by: Russell King > --- > drivers/gpu/drm/bridge/synopsys/Kconfig | 8 + > drivers/gpu/drm/bridge/synopsys/Makefile | 1 + >

Re: [PATCH 4/4] drm/bridge: dw-hdmi: add cec driver

On 06/01/17 11:46, Russell King - ARM Linux wrote: > On Thu, Jun 01, 2017 at 10:31:10AM +0200, Hans Verkuil wrote: >> Hi Russell, >> >> First a few top-level questions: > > Hi Hans, > >> 1) What was the reason for using the cec-notifier here? Isn't this >>tightly integrated into the main

Re: [PATCH 4/4] drm/bridge: dw-hdmi: add cec driver

Hi Russell, First a few top-level questions: 1) What was the reason for using the cec-notifier here? Isn't this tightly integrated into the main dw-hdmi block? For the tda driver it is clearly required, but for tightly coupled HDMI & CEC HW I just create the adapter from the HDMI

[PATCH 4/4] drm/bridge: dw-hdmi: add cec driver

Add a CEC driver for the dw-hdmi hardware. Signed-off-by: Russell King --- drivers/gpu/drm/bridge/synopsys/Kconfig | 8 + drivers/gpu/drm/bridge/synopsys/Makefile | 1 + drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c | 320 ++