Re: [Nouveau] [PATCH 4/5] drm/nouveau: Grab RPM ref when i2c bus is in use

2018-07-17 Thread Karol Herbst
On Tue, Jul 17, 2018 at 1:54 PM, Ben Skeggs wrote: > On Tue, 17 Jul 2018 at 20:18, Karol Herbst wrote: >> >> mhh, we shouldn't call to Linux APIs from within of nvkm. Rather gaurd >> the Linux glue code to the i2c stuff instead, but this is all done >> from inside of nvkm. I think we should move

Re: [Nouveau] [PATCH 4/5] drm/nouveau: Grab RPM ref when i2c bus is in use

2018-07-17 Thread Ben Skeggs
On Tue, 17 Jul 2018 at 20:18, Karol Herbst wrote: > > mhh, we shouldn't call to Linux APIs from within of nvkm. Rather gaurd > the Linux glue code to the i2c stuff instead, but this is all done > from inside of nvkm. I think we should move it out into > drm/nouveau/nouveau_i2c.c and do the

Re: [Nouveau] [PATCH 4/5] drm/nouveau: Grab RPM ref when i2c bus is in use

2018-07-17 Thread Karol Herbst
mhh, we shouldn't call to Linux APIs from within of nvkm. Rather gaurd the Linux glue code to the i2c stuff instead, but this is all done from inside of nvkm. I think we should move it out into drm/nouveau/nouveau_i2c.c and do the handling there. On Tue, Jul 17, 2018 at 1:59 AM, Lyude Paul

[PATCH 4/5] drm/nouveau: Grab RPM ref when i2c bus is in use

2018-07-16 Thread Lyude Paul
The i2c bus can be both accessed by DRM itself, along with any of it's devnodes (/sys/class/i2c). So, we need to make sure that all codepaths using the i2c bus keep the GPU resumed. Signed-off-by: Lyude Paul Cc: Karol Herbst Cc: sta...@vger.kernel.org ---