Re: [PATCH 4/6] drm/vc4: Rework the async update logic

2018-11-19 Thread Eric Anholt
Boris Brezillon writes: > On Thu, 15 Nov 2018 12:49:11 -0800 > Eric Anholt wrote: > >> Boris Brezillon writes: >> >> > vc4_plane_atomic_async_check() was only based on the >> > state->{crtc,src}_{w,h} which was fine since scaling was not allowed on >> > the cursor plane. >> > >> > We are about

Re: [PATCH 4/6] drm/vc4: Rework the async update logic

2018-11-15 Thread Boris Brezillon
On Thu, 15 Nov 2018 12:49:11 -0800 Eric Anholt wrote: > Boris Brezillon writes: > > > vc4_plane_atomic_async_check() was only based on the > > state->{crtc,src}_{w,h} which was fine since scaling was not allowed on > > the cursor plane. > > > > We are about to change that to properly support un

Re: [PATCH 4/6] drm/vc4: Rework the async update logic

2018-11-15 Thread Eric Anholt
Boris Brezillon writes: > vc4_plane_atomic_async_check() was only based on the > state->{crtc,src}_{w,h} which was fine since scaling was not allowed on > the cursor plane. > > We are about to change that to properly support underscan, and, in order > to make the async check more reliable, we cal

[PATCH 4/6] drm/vc4: Rework the async update logic

2018-11-15 Thread Boris Brezillon
vc4_plane_atomic_async_check() was only based on the state->{crtc,src}_{w,h} which was fine since scaling was not allowed on the cursor plane. We are about to change that to properly support underscan, and, in order to make the async check more reliable, we call vc4_plane_mode_set() from there and