Re: [PATCH 4/6] drm: rcar-du: Add quirk for H3 ES1 pclk WA

2023-01-20 Thread Tomi Valkeinen
On 18/01/2023 23:19, Laurent Pinchart wrote: Hi Tomi, Thank you for the patch. On Tue, Jan 17, 2023 at 03:51:52PM +0200, Tomi Valkeinen wrote: rcar_du_crtc.c does a soc_device_match() in rcar_du_crtc_set_display_timing() to find out if the SoC is H3 ES1, and s/ES1/ES1.x/ Same below. if

Re: [PATCH 4/6] drm: rcar-du: Add quirk for H3 ES1 pclk WA

2023-01-20 Thread Tomi Valkeinen
On 17/01/2023 18:11, Geert Uytterhoeven wrote: Hi Tomi, On Tue, Jan 17, 2023 at 2:54 PM Tomi Valkeinen wrote: rcar_du_crtc.c does a soc_device_match() in rcar_du_crtc_set_display_timing() to find out if the SoC is H3 ES1, and if so, apply a WA. We will need another H3 ES1 check in the

Re: [PATCH 4/6] drm: rcar-du: Add quirk for H3 ES1 pclk WA

2023-01-18 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Tue, Jan 17, 2023 at 03:51:52PM +0200, Tomi Valkeinen wrote: > rcar_du_crtc.c does a soc_device_match() in > rcar_du_crtc_set_display_timing() to find out if the SoC is H3 ES1, and s/ES1/ES1.x/ Same below. > if so, apply a WA. s/WA/workaround/ Same

[PATCH 4/6] drm: rcar-du: Add quirk for H3 ES1 pclk WA

2023-01-18 Thread Tomi Valkeinen
rcar_du_crtc.c does a soc_device_match() in rcar_du_crtc_set_display_timing() to find out if the SoC is H3 ES1, and if so, apply a WA. We will need another H3 ES1 check in the following patch, so rather than adding more soc_device_match() calls, let's add a rcar_du_device_info entry for the ES1,

Re: [PATCH 4/6] drm: rcar-du: Add quirk for H3 ES1 pclk WA

2023-01-17 Thread Geert Uytterhoeven
Hi Tomi, On Tue, Jan 17, 2023 at 2:54 PM Tomi Valkeinen wrote: > rcar_du_crtc.c does a soc_device_match() in > rcar_du_crtc_set_display_timing() to find out if the SoC is H3 ES1, and > if so, apply a WA. > > We will need another H3 ES1 check in the following patch, so rather than > adding more