Re: [PATCH 4/7] drm/pl111: Enable PL110 variant

2017-09-01 Thread Linus Walleij
On Fri, Sep 1, 2017 at 10:23 AM, Emil Velikov wrote: >>Eric E: >>> +struct pl111_variant_data pl110_variant = { >> >> I think this (and `pl111_variant` below) can be `static const`, right? >> > Static - yes, const - I don't think so. > Struct amba_id::data lacks the constness, so the const qualif

Re: [PATCH 4/7] drm/pl111: Enable PL110 variant

2017-09-01 Thread Emil Velikov
On 31 August 2017 at 11:19, Eric Engestrom wrote: > On Wednesday, 2017-08-30 20:07:08 +0200, Linus Walleij wrote: >> We detect and enable the use of the PL110 variant, an earlier >> incarnation of PL111. The only real difference is that the >> control and interrupt enable registers have swapped pl

Re: [PATCH 4/7] drm/pl111: Enable PL110 variant

2017-08-31 Thread Eric Anholt
Linus Walleij writes: > We detect and enable the use of the PL110 variant, an earlier > incarnation of PL111. The only real difference is that the > control and interrupt enable registers have swapped place. > The Versatile AB and Versatile PB have a variant inbetween > PL110 and PL111, it is PL1

Re: [PATCH 4/7] drm/pl111: Enable PL110 variant

2017-08-31 Thread Eric Engestrom
On Wednesday, 2017-08-30 20:07:08 +0200, Linus Walleij wrote: > We detect and enable the use of the PL110 variant, an earlier > incarnation of PL111. The only real difference is that the > control and interrupt enable registers have swapped place. > The Versatile AB and Versatile PB have a variant

[PATCH 4/7] drm/pl111: Enable PL110 variant

2017-08-30 Thread Linus Walleij
We detect and enable the use of the PL110 variant, an earlier incarnation of PL111. The only real difference is that the control and interrupt enable registers have swapped place. The Versatile AB and Versatile PB have a variant inbetween PL110 and PL111, it is PL110 but they have already swapped t