[PATCH 5/9] drm/edid: Move validate_displayid() drm_find_displayid_extension()

[Ville Syrjala]

From: Ville Syrjälä <ville.syrj...@linux.intel.com>

Instead of everyone having to call validate_displayid() let's just
have drm_find_displayid_extension() do it for them.

Signed-off-by: Ville Syrjälä <ville.syrj...@linux.intel.com>
---
 drivers/gpu/drm/drm_edid.c | 19 +++++--------------
 1 file changed, 5 insertions(+), 14 deletions(-)

diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
index 18c55f3b20de..dbd2e8474c2a 100644
--- a/drivers/gpu/drm/drm_edid.c
+++ b/drivers/gpu/drm/drm_edid.c
@@ -3216,6 +3216,7 @@ static u8 *drm_find_displayid_extension(const struct edid 
*edid,
                                        int *length, int *idx)
 {
        u8 *displayid = drm_find_edid_extension(edid, DISPLAYID_EXT);
+       int ret;
 
        if (!displayid)
                return NULL;
@@ -3223,12 +3224,15 @@ static u8 *drm_find_displayid_extension(const struct 
edid *edid,
        *length = EDID_LENGTH;
        *idx = 1;
 
+       ret = validate_displayid(displayid, *length, *idx);
+       if (ret)
+               return NULL;
+
        return displayid;
 }
 
 static u8 *drm_find_cea_extension(const struct edid *edid)
 {
-       int ret;
        int length, idx;
        struct displayid_block *block;
        u8 *cea;
@@ -3244,10 +3248,6 @@ static u8 *drm_find_cea_extension(const struct edid 
*edid)
        if (!displayid)
                return NULL;
 
-       ret = validate_displayid(displayid, length, idx);
-       if (ret)
-               return NULL;
-
        idx += sizeof(struct displayid_hdr);
        for_each_displayid_db(displayid, block, idx, length) {
                if (block->tag == DATA_BLOCK_CTA) {
@@ -5189,7 +5189,6 @@ static int add_displayid_detailed_modes(struct 
drm_connector *connector,
                                        struct edid *edid)
 {
        u8 *displayid;
-       int ret;
        int length, idx;
        struct displayid_block *block;
        int num_modes = 0;
@@ -5198,10 +5197,6 @@ static int add_displayid_detailed_modes(struct 
drm_connector *connector,
        if (!displayid)
                return 0;
 
-       ret = validate_displayid(displayid, length, idx);
-       if (ret)
-               return 0;
-
        idx += sizeof(struct displayid_hdr);
        for_each_displayid_db(displayid, block, idx, length) {
                switch (block->tag) {
@@ -5849,10 +5844,6 @@ static int drm_parse_display_id(struct drm_connector 
*connector,
        struct displayid_block *block;
        int ret;
 
-       ret = validate_displayid(displayid, length, idx);
-       if (ret)
-               return ret;
-
        idx += sizeof(struct displayid_hdr);
        for_each_displayid_db(displayid, block, idx, length) {
                DRM_DEBUG_KMS("block id 0x%x, rev %d, len %d\n",
-- 
2.24.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel