Re: [PATCH 6/7] drm/amdgpu: Ensure kunmap is called on error

2021-12-16 Thread Christian König
Am 15.12.21 um 22:09 schrieb Ira Weiny: On Tue, Dec 14, 2021 at 08:09:29AM +0100, Christian König wrote: Am 14.12.21 um 04:37 schrieb Ira Weiny: On Mon, Dec 13, 2021 at 09:37:32PM +0100, Christian König wrote: Am 11.12.21 um 00:24 schrieb ira.we...@intel.com: From: Ira Weiny The default

Re: [PATCH 6/7] drm/amdgpu: Ensure kunmap is called on error

2021-12-15 Thread Ira Weiny
On Tue, Dec 14, 2021 at 08:09:29AM +0100, Christian König wrote: > Am 14.12.21 um 04:37 schrieb Ira Weiny: > > On Mon, Dec 13, 2021 at 09:37:32PM +0100, Christian König wrote: > > > Am 11.12.21 um 00:24 schrieb ira.we...@intel.com: > > > > From: Ira Weiny > > > > > > > > The default case leaves

Re: [PATCH 6/7] drm/amdgpu: Ensure kunmap is called on error

2021-12-13 Thread Christian König
Am 14.12.21 um 04:37 schrieb Ira Weiny: On Mon, Dec 13, 2021 at 09:37:32PM +0100, Christian König wrote: Am 11.12.21 um 00:24 schrieb ira.we...@intel.com: From: Ira Weiny The default case leaves the buffer object mapped in error. Add amdgpu_bo_kunmap() to that case to ensure the mapping is

Re: [PATCH 6/7] drm/amdgpu: Ensure kunmap is called on error

2021-12-13 Thread Ira Weiny
On Mon, Dec 13, 2021 at 09:37:32PM +0100, Christian König wrote: > Am 11.12.21 um 00:24 schrieb ira.we...@intel.com: > > From: Ira Weiny > > > > The default case leaves the buffer object mapped in error. > > > > Add amdgpu_bo_kunmap() to that case to ensure the mapping is cleaned up. > > Mhm,

Re: [PATCH 6/7] drm/amdgpu: Ensure kunmap is called on error

2021-12-13 Thread Christian König
Am 11.12.21 um 00:24 schrieb ira.we...@intel.com: From: Ira Weiny The default case leaves the buffer object mapped in error. Add amdgpu_bo_kunmap() to that case to ensure the mapping is cleaned up. Mhm, good catch. But why do you want to do this in the first place? Christian.

[PATCH 6/7] drm/amdgpu: Ensure kunmap is called on error

2021-12-10 Thread ira . weiny
From: Ira Weiny The default case leaves the buffer object mapped in error. Add amdgpu_bo_kunmap() to that case to ensure the mapping is cleaned up. Signed-off-by: Ira Weiny --- NOTE: It seems like this function could use a fair bit of refactoring but this is the easiest way to fix the actual