Re: [PATCH 6/8] drm/msm: dpu: Separate crtc assignment from vblank enable

2018-11-14 Thread Jeykumar Sankaran
On 2018-11-14 12:52, Sean Paul wrote: On Wed, Nov 14, 2018 at 12:46:32PM -0800, Jeykumar Sankaran wrote: On 2018-11-14 11:57, Ville Syrjälä wrote: > On Wed, Nov 14, 2018 at 11:43:51AM -0800, Jeykumar Sankaran wrote: > > On 2018-11-14 07:16, Sean Paul wrote: > > > On Tue, Nov 13, 2018 at

Re: [PATCH 6/8] drm/msm: dpu: Separate crtc assignment from vblank enable

2018-11-14 Thread Sean Paul
On Wed, Nov 14, 2018 at 12:46:32PM -0800, Jeykumar Sankaran wrote: > On 2018-11-14 11:57, Ville Syrjälä wrote: > > On Wed, Nov 14, 2018 at 11:43:51AM -0800, Jeykumar Sankaran wrote: > > > On 2018-11-14 07:16, Sean Paul wrote: > > > > On Tue, Nov 13, 2018 at 04:48:12PM -0800, Jeykumar Sankaran

Re: [PATCH 6/8] drm/msm: dpu: Separate crtc assignment from vblank enable

2018-11-14 Thread Jeykumar Sankaran
On 2018-11-14 11:57, Ville Syrjälä wrote: On Wed, Nov 14, 2018 at 11:43:51AM -0800, Jeykumar Sankaran wrote: On 2018-11-14 07:16, Sean Paul wrote: > On Tue, Nov 13, 2018 at 04:48:12PM -0800, Jeykumar Sankaran wrote: >> On 2018-11-13 12:52, Sean Paul wrote: >> > From: Sean Paul >> > >> >

Re: [PATCH 6/8] drm/msm: dpu: Separate crtc assignment from vblank enable

2018-11-14 Thread Ville Syrjälä
On Wed, Nov 14, 2018 at 11:43:51AM -0800, Jeykumar Sankaran wrote: > On 2018-11-14 07:16, Sean Paul wrote: > > On Tue, Nov 13, 2018 at 04:48:12PM -0800, Jeykumar Sankaran wrote: > >> On 2018-11-13 12:52, Sean Paul wrote: > >> > From: Sean Paul > >> > > >> > Instead of assigning/clearing the crtc

Re: [PATCH 6/8] drm/msm: dpu: Separate crtc assignment from vblank enable

2018-11-14 Thread Sean Paul
On Wed, Nov 14, 2018 at 11:43:51AM -0800, Jeykumar Sankaran wrote: > On 2018-11-14 07:16, Sean Paul wrote: > > On Tue, Nov 13, 2018 at 04:48:12PM -0800, Jeykumar Sankaran wrote: > > > On 2018-11-13 12:52, Sean Paul wrote: > > > > From: Sean Paul > > > > > > > > Instead of assigning/clearing the

Re: [PATCH 6/8] drm/msm: dpu: Separate crtc assignment from vblank enable

2018-11-14 Thread Jeykumar Sankaran
On 2018-11-14 07:16, Sean Paul wrote: On Tue, Nov 13, 2018 at 04:48:12PM -0800, Jeykumar Sankaran wrote: On 2018-11-13 12:52, Sean Paul wrote: > From: Sean Paul > > Instead of assigning/clearing the crtc on vblank enable/disable, we can > just assign and clear the crtc on modeset. That

Re: [PATCH 6/8] drm/msm: dpu: Separate crtc assignment from vblank enable

2018-11-14 Thread Sean Paul
On Tue, Nov 13, 2018 at 04:48:12PM -0800, Jeykumar Sankaran wrote: > On 2018-11-13 12:52, Sean Paul wrote: > > From: Sean Paul > > > > Instead of assigning/clearing the crtc on vblank enable/disable, we can > > just assign and clear the crtc on modeset. That allows us to just toggle > > the

Re: [PATCH 6/8] drm/msm: dpu: Separate crtc assignment from vblank enable

2018-11-13 Thread Jeykumar Sankaran
On 2018-11-13 12:52, Sean Paul wrote: From: Sean Paul Instead of assigning/clearing the crtc on vblank enable/disable, we can just assign and clear the crtc on modeset. That allows us to just toggle the encoder's vblank interrupts on vblank_enable. So why is this important? Previously the

[PATCH 6/8] drm/msm: dpu: Separate crtc assignment from vblank enable

2018-11-13 Thread Sean Paul
From: Sean Paul Instead of assigning/clearing the crtc on vblank enable/disable, we can just assign and clear the crtc on modeset. That allows us to just toggle the encoder's vblank interrupts on vblank_enable. So why is this important? Previously the driver was using the legacy pointers to