Re: [PATCH 8/8] drm/fourcc: Add DRM_FORMAT_D1

2022-02-17 Thread Sam Ravnborg
Hi Geert, > > C1 is color-indexed, which can be any two colors. > R1 is light-on-dark. > D1 is dark-on-light. It would be nice to have this explained in the fourcc.h file, preferably with a little more verbosity than the current explanations. Sam

Re: [PATCH 8/8] drm/fourcc: Add DRM_FORMAT_D1

2022-02-17 Thread Pekka Paalanen
On Thu, 17 Feb 2022 11:42:29 +0100 Geert Uytterhoeven wrote: > Hi Pekka, > > On Thu, Feb 17, 2022 at 11:10 AM Pekka Paalanen wrote: > > On Tue, 15 Feb 2022 17:52:26 +0100 > > Geert Uytterhoeven wrote: > > > Introduce a fourcc code for a single-channel frame buffer format with two > > >

Re: [PATCH 8/8] drm/fourcc: Add DRM_FORMAT_D1

2022-02-17 Thread Geert Uytterhoeven
Hi Pekka, On Thu, Feb 17, 2022 at 11:10 AM Pekka Paalanen wrote: > On Tue, 15 Feb 2022 17:52:26 +0100 > Geert Uytterhoeven wrote: > > Introduce a fourcc code for a single-channel frame buffer format with two > > darkness levels. This can be used for two-level dark-on-light displays. > > > > As

Re: [PATCH 8/8] drm/fourcc: Add DRM_FORMAT_D1

2022-02-17 Thread Simon Ser
Hi, On Tuesday, February 15th, 2022 at 17:52, Geert Uytterhoeven wrote: > Introduce a fourcc code for a single-channel frame buffer format with two > darkness levels. This can be used for two-level dark-on-light displays. The previous patches introduce C1 and R1. Do we really need D1? Can't

Re: [PATCH 8/8] drm/fourcc: Add DRM_FORMAT_D1

2022-02-17 Thread Pekka Paalanen
On Tue, 15 Feb 2022 17:52:26 +0100 Geert Uytterhoeven wrote: > Introduce a fourcc code for a single-channel frame buffer format with two > darkness levels. This can be used for two-level dark-on-light displays. > > As the number of bits per pixel is less than eight, this relies on > proper

[PATCH 8/8] drm/fourcc: Add DRM_FORMAT_D1

2022-02-15 Thread Geert Uytterhoeven
Introduce a fourcc code for a single-channel frame buffer format with two darkness levels. This can be used for two-level dark-on-light displays. As the number of bits per pixel is less than eight, this relies on proper block handling for the calculation of bits per pixel and pitch.