Re: [PATCH 8/8] dt-bindings: display: Add SSD132x OLED controllers

2023-10-11 Thread Conor Dooley
On Wed, Oct 11, 2023 at 08:34:29AM +0200, Javier Martinez Canillas wrote: > Conor Dooley writes: > >> + # Only required for SPI > >> + dc-gpios: > >> +description: > >> + GPIO connected to the controller's D/C# (Data/Command) pin, > >> + that is needed for 4-wire SPI to tell the

Re: [PATCH 8/8] dt-bindings: display: Add SSD132x OLED controllers

2023-10-11 Thread Javier Martinez Canillas
Javier Martinez Canillas writes: > Rob Herring writes: > > Hello Rob, > > Thanks a lot for your feedback. > >> On Mon, Oct 09, 2023 at 08:34:22PM +0200, Javier Martinez Canillas wrote: >>> Add a Device Tree binding schema for the OLED panels based on the Solomon >>> SSD132x family of

Re: [PATCH 8/8] dt-bindings: display: Add SSD132x OLED controllers

2023-10-11 Thread Javier Martinez Canillas
Rob Herring writes: Hello Rob, Thanks a lot for your feedback. > On Mon, Oct 09, 2023 at 08:34:22PM +0200, Javier Martinez Canillas wrote: >> Add a Device Tree binding schema for the OLED panels based on the Solomon >> SSD132x family of controllers. > > Looks like the same binding as

Re: [PATCH 8/8] dt-bindings: display: Add SSD132x OLED controllers

2023-10-11 Thread Javier Martinez Canillas
Conor Dooley writes: Hello Conor, Thanks a lot for your feedback. > Hey, > > On Mon, Oct 09, 2023 at 08:34:22PM +0200, Javier Martinez Canillas wrote: [...] >> +properties: >> + compatible: >> +oneOf: >> + - enum: >> + - solomon,ssd1322 >> + - solomon,ssd1325 >> +

Re: [PATCH 8/8] dt-bindings: display: Add SSD132x OLED controllers

2023-10-10 Thread Rob Herring
On Mon, Oct 09, 2023 at 08:34:22PM +0200, Javier Martinez Canillas wrote: > Add a Device Tree binding schema for the OLED panels based on the Solomon > SSD132x family of controllers. Looks like the same binding as solomon,ssd1307fb.yaml. Why a different binding? Why does that binding need a slew

Re: [PATCH 8/8] dt-bindings: display: Add SSD132x OLED controllers

2023-10-10 Thread Conor Dooley
Hey, On Mon, Oct 09, 2023 at 08:34:22PM +0200, Javier Martinez Canillas wrote: > Add a Device Tree binding schema for the OLED panels based on the Solomon > SSD132x family of controllers. > > Signed-off-by: Javier Martinez Canillas > --- > > .../bindings/display/solomon,ssd132x.yaml | 116

[PATCH 8/8] dt-bindings: display: Add SSD132x OLED controllers

2023-10-09 Thread Javier Martinez Canillas
Add a Device Tree binding schema for the OLED panels based on the Solomon SSD132x family of controllers. Signed-off-by: Javier Martinez Canillas --- .../bindings/display/solomon,ssd132x.yaml | 116 ++ 1 file changed, 116 insertions(+) create mode 100644