[PATCH RFC 3/6] drm/tilcdc: Add support for external compontised DRM encoder

2015-03-06 Thread Jyri Sarha
On 03/06/15 11:58, Russell King - ARM Linux wrote: > On Fri, Mar 06, 2015 at 10:33:27AM +0200, Jyri Sarha wrote: >> Would it be Ok to add a check that master->ops->add_components is defined, >> before calling it in find_componets() (drivers/base/component.c:120) and >> return 0 if it is not? > >

[PATCH RFC 3/6] drm/tilcdc: Add support for external compontised DRM encoder

2015-03-06 Thread Russell King - ARM Linux
On Fri, Mar 06, 2015 at 12:21:42PM +0200, Jyri Sarha wrote: > On 03/06/15 11:58, Russell King - ARM Linux wrote: > >On Fri, Mar 06, 2015 at 10:33:27AM +0200, Jyri Sarha wrote: > >>Would it be Ok to add a check that master->ops->add_components is defined, > >>before calling it in find_componets()

[PATCH RFC 3/6] drm/tilcdc: Add support for external compontised DRM encoder

2015-03-06 Thread Jyri Sarha
On 03/02/15 18:01, Russell King - ARM Linux wrote: > On Thu, Feb 26, 2015 at 04:55:32PM +0200, Jyri Sarha wrote: >> +ret = component_bind_all(dev->dev, dev); >> +if (ret < 0) { >> +dev_err(dev->dev, "Binding subcomponents failed: %d\n", ret); > > Do you need to print this? The

[PATCH RFC 3/6] drm/tilcdc: Add support for external compontised DRM encoder

2015-03-06 Thread Russell King - ARM Linux
On Fri, Mar 06, 2015 at 10:33:27AM +0200, Jyri Sarha wrote: > Would it be Ok to add a check that master->ops->add_components is defined, > before calling it in find_componets() (drivers/base/component.c:120) and > return 0 if it is not? No:

[PATCH RFC 3/6] drm/tilcdc: Add support for external compontised DRM encoder

2015-03-02 Thread Russell King - ARM Linux
On Thu, Feb 26, 2015 at 04:55:32PM +0200, Jyri Sarha wrote: > + ret = component_bind_all(dev->dev, dev); > + if (ret < 0) { > + dev_err(dev->dev, "Binding subcomponents failed: %d\n", ret); Do you need to print this? The component helper is already fairly verbose about what

[PATCH RFC 3/6] drm/tilcdc: Add support for external compontised DRM encoder

2015-03-02 Thread Tomi Valkeinen
On 26/02/15 16:55, Jyri Sarha wrote: > Add support for an external compontised DRM encoder. The external > encoder can be connected to tilcdc trough device tree graph binding. > The binding document for tilcdc has been updated. The support has only > been tested with tda998x encoder, but other

[PATCH RFC 3/6] drm/tilcdc: Add support for external compontised DRM encoder

2015-02-26 Thread Jyri Sarha
Add support for an external compontised DRM encoder. The external encoder can be connected to tilcdc trough device tree graph binding. The binding document for tilcdc has been updated. The support has only been tested with tda998x encoder, but other encoders should work too with a little tweaking.