Re: [PATCH RFC v7 5/6] dt-bindings: display: add Unisoc's mipi dsi bindings
Hi maxime, Sorry, I forgot to describe ports subnode with my two port@X, i will be fix it. Thanks for reminding Maxime Ripard 于2020年9月28日周一 下午4:20写道： > > Hi! > > On Mon, Sep 28, 2020 at 02:27:39PM +0800, Kevin Tang wrote: > > From: Kevin Tang > > > > Adds MIPI DSI Master and MIPI DSI-PHY (D-PHY) > > support for Unisoc's display subsystem. > > > > RFC v7: > > - Fix DTC unit name warnings > > - Fix the problem of maintainers > > > > Cc: Orson Zhai > > Cc: Chunyan Zhang > > Signed-off-by: Kevin Tang > > --- > > .../display/sprd/sprd,sharkl3-dsi-host.yaml| 98 > > ++ > > .../display/sprd/sprd,sharkl3-dsi-phy.yaml | 75 + > > 2 files changed, 173 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/display/sprd/sprd,sharkl3-dsi-host.yaml > > create mode 100644 > > Documentation/devicetree/bindings/display/sprd/sprd,sharkl3-dsi-phy.yaml > > > > diff --git > > a/Documentation/devicetree/bindings/display/sprd/sprd,sharkl3-dsi-host.yaml > > b/Documentation/devicetree/bindings/display/sprd/sprd,sharkl3-dsi-host.yaml > > new file mode 100644 > > index 000..b6bbf67 > > --- /dev/null > > +++ > > b/Documentation/devicetree/bindings/display/sprd/sprd,sharkl3-dsi-host.yaml > > @@ -0,0 +1,98 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/display/sprd/sprd,sharkl3-dsi-host.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Unisoc MIPI DSI Controller > > + > > +maintainers: > > + - Kevin Tang > > + > > +properties: > > + compatible: > > +const: sprd,sharkl3-dsi-host > > + > > + reg: > > +maxItems: 1 > > +description: > > + Physical base address and length of the registers set for the device. > > + > > + interrupts: > > +maxItems: 2 > > +description: > > + Should contain DSI interrupt. > > + > > + clocks: > > +minItems: 1 > > + > > + clock-names: > > +items: > > + - const: clk_src_96m > > + > > + power-domains: > > +maxItems: 1 > > +description: A phandle to DSIM power domain node > > + > > + "#address-cells": > > +const: 1 > > + > > + "#size-cells": > > +const: 0 > > + > > + port@0: > > +type: object > > +description: > > + A port node with endpoint definitions as defined in > > + Documentation/devicetree/bindings/media/video-interfaces.txt. > > + That port should be the input endpoint, usually coming from > > + the associated DPU. > > + port@1: > > +type: object > > +description: > > + A port node with endpoint definitions as defined in > > + Documentation/devicetree/bindings/media/video-interfaces.txt. > > + That port should be the output endpoint, usually output to > > + the associated DPHY. > > Is there a specific reason you don't follow the OF-graph and have a > ports subnode with your two port@X in there? > > Maxime ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH RFC v7 5/6] dt-bindings: display: add Unisoc's mipi dsi bindings
Hi! On Mon, Sep 28, 2020 at 02:27:39PM +0800, Kevin Tang wrote: > From: Kevin Tang > > Adds MIPI DSI Master and MIPI DSI-PHY (D-PHY) > support for Unisoc's display subsystem. > > RFC v7: > - Fix DTC unit name warnings > - Fix the problem of maintainers > > Cc: Orson Zhai > Cc: Chunyan Zhang > Signed-off-by: Kevin Tang > --- > .../display/sprd/sprd,sharkl3-dsi-host.yaml| 98 > ++ > .../display/sprd/sprd,sharkl3-dsi-phy.yaml | 75 + > 2 files changed, 173 insertions(+) > create mode 100644 > Documentation/devicetree/bindings/display/sprd/sprd,sharkl3-dsi-host.yaml > create mode 100644 > Documentation/devicetree/bindings/display/sprd/sprd,sharkl3-dsi-phy.yaml > > diff --git > a/Documentation/devicetree/bindings/display/sprd/sprd,sharkl3-dsi-host.yaml > b/Documentation/devicetree/bindings/display/sprd/sprd,sharkl3-dsi-host.yaml > new file mode 100644 > index 000..b6bbf67 > --- /dev/null > +++ > b/Documentation/devicetree/bindings/display/sprd/sprd,sharkl3-dsi-host.yaml > @@ -0,0 +1,98 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/sprd/sprd,sharkl3-dsi-host.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Unisoc MIPI DSI Controller > + > +maintainers: > + - Kevin Tang > + > +properties: > + compatible: > +const: sprd,sharkl3-dsi-host > + > + reg: > +maxItems: 1 > +description: > + Physical base address and length of the registers set for the device. > + > + interrupts: > +maxItems: 2 > +description: > + Should contain DSI interrupt. > + > + clocks: > +minItems: 1 > + > + clock-names: > +items: > + - const: clk_src_96m > + > + power-domains: > +maxItems: 1 > +description: A phandle to DSIM power domain node > + > + "#address-cells": > +const: 1 > + > + "#size-cells": > +const: 0 > + > + port@0: > +type: object > +description: > + A port node with endpoint definitions as defined in > + Documentation/devicetree/bindings/media/video-interfaces.txt. > + That port should be the input endpoint, usually coming from > + the associated DPU. > + port@1: > +type: object > +description: > + A port node with endpoint definitions as defined in > + Documentation/devicetree/bindings/media/video-interfaces.txt. > + That port should be the output endpoint, usually output to > + the associated DPHY. Is there a specific reason you don't follow the OF-graph and have a ports subnode with your two port@X in there? Maxime signature.asc Description: PGP signature ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
[PATCH RFC v7 5/6] dt-bindings: display: add Unisoc's mipi dsi bindings
From: Kevin Tang
Adds MIPI DSI Master and MIPI DSI-PHY (D-PHY)
support for Unisoc's display subsystem.
RFC v7:
- Fix DTC unit name warnings
- Fix the problem of maintainers
Cc: Orson Zhai
Cc: Chunyan Zhang
Signed-off-by: Kevin Tang
---
.../display/sprd/sprd,sharkl3-dsi-host.yaml| 98 ++
.../display/sprd/sprd,sharkl3-dsi-phy.yaml | 75 +
2 files changed, 173 insertions(+)
create mode 100644
Documentation/devicetree/bindings/display/sprd/sprd,sharkl3-dsi-host.yaml
create mode 100644
Documentation/devicetree/bindings/display/sprd/sprd,sharkl3-dsi-phy.yaml
diff --git
a/Documentation/devicetree/bindings/display/sprd/sprd,sharkl3-dsi-host.yaml
b/Documentation/devicetree/bindings/display/sprd/sprd,sharkl3-dsi-host.yaml
new file mode 100644
index 000..b6bbf67
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/sprd/sprd,sharkl3-dsi-host.yaml
@@ -0,0 +1,98 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/sprd/sprd,sharkl3-dsi-host.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Unisoc MIPI DSI Controller
+
+maintainers:
+ - Kevin Tang
+
+properties:
+ compatible:
+const: sprd,sharkl3-dsi-host
+
+ reg:
+maxItems: 1
+description:
+ Physical base address and length of the registers set for the device.
+
+ interrupts:
+maxItems: 2
+description:
+ Should contain DSI interrupt.
+
+ clocks:
+minItems: 1
+
+ clock-names:
+items:
+ - const: clk_src_96m
+
+ power-domains:
+maxItems: 1
+description: A phandle to DSIM power domain node
+
+ "#address-cells":
+const: 1
+
+ "#size-cells":
+const: 0
+
+ port@0:
+type: object
+description:
+ A port node with endpoint definitions as defined in
+ Documentation/devicetree/bindings/media/video-interfaces.txt.
+ That port should be the input endpoint, usually coming from
+ the associated DPU.
+ port@1:
+type: object
+description:
+ A port node with endpoint definitions as defined in
+ Documentation/devicetree/bindings/media/video-interfaces.txt.
+ That port should be the output endpoint, usually output to
+ the associated DPHY.
+
+required:
+ - compatible
+ - reg
+ - interrupts
+ - clocks
+ - clock-names
+ - port@0
+ - port@1
+ - "#address-cells"
+ - "#size-cells"
+
+additionalProperties: false
+
+examples:
+ - |
+#include
+#include
+dsi: dsi@6310 {
+compatible = "sprd,sharkl3-dsi-host";
+reg = <0x6310 0x1000>;
+interrupts = ,
+ ;
+clock-names = "clk_src_96m";
+clocks = < CLK_TWPLL_96M>;
+
+#address-cells = <1>;
+#size-cells = <0>;
+port@0 {
+reg = <0>;
+dsi_in: endpoint {
+remote-endpoint = <_out>;
+};
+};
+
+port@1 {
+reg = <1>;
+dsi_out: endpoint {
+remote-endpoint = <_in>;
+};
+};
+};
diff --git
a/Documentation/devicetree/bindings/display/sprd/sprd,sharkl3-dsi-phy.yaml
b/Documentation/devicetree/bindings/display/sprd/sprd,sharkl3-dsi-phy.yaml
new file mode 100644
index 000..0ab8c33
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/sprd/sprd,sharkl3-dsi-phy.yaml
@@ -0,0 +1,75 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/sprd/sprd,sharkl3-dsi-phy.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Unisoc MIPI DSI-PHY (D-PHY)
+
+maintainers:
+ - Kevin Tang
+
+properties:
+ compatible:
+const: sprd,sharkl3-dsi-phy
+
+ reg:
+maxItems: 1
+description:
+ Must be the dsi controller base address.
+
+ "#address-cells":
+const: 1
+
+ "#size-cells":
+const: 0
+
+ port@0:
+type: object
+description:
+ A port node with endpoint definitions as defined in
+ Documentation/devicetree/bindings/media/video-interfaces.txt.
+ That port should be the output endpoint, usually output to
+ the associated panel.
+ port@1:
+type: object
+description:
+ A port node with endpoint definitions as defined in
+ Documentation/devicetree/bindings/media/video-interfaces.txt.
+ That port should be the input endpoint, usually coming from
+ the associated DSI controller.
+
+required:
+ - compatible
+ - reg
+ - port@0
+ - port@1
+ - "#address-cells"
+ - "#size-cells"
+
+additionalProperties: false
+
+examples:
+ - |
+dphy: dphy@6310 {
+compatible = "sprd,sharkl3-dsi-phy";
+reg = <0x6310 0x1000>;
+#address-cells = <1>;
+#size-cells = <0>;
+
+/* input port*/
+port@1 {
+reg = <1>;
+dphy_in: endpoint {
+ remote-endpoint = <_out>;
+};
+};
+
+/* output port */
