Re: [PATCH V3 4/5] drm/vkms: Compute CRC without change input data

2019-07-16 Thread Rodrigo Siqueira
On 07/16, Daniel Vetter wrote: > On Fri, Jul 12, 2019 at 12:14:49AM -0300, Rodrigo Siqueira wrote: > > On 07/11, Daniel Vetter wrote: > > > On Tue, Jun 25, 2019 at 10:38:31PM -0300, Rodrigo Siqueira wrote: > > > > The compute_crc() function is responsible for calculating the > > > > framebuffer

Re: [PATCH V3 4/5] drm/vkms: Compute CRC without change input data

2019-07-16 Thread Daniel Vetter
On Fri, Jul 12, 2019 at 12:14:49AM -0300, Rodrigo Siqueira wrote: > On 07/11, Daniel Vetter wrote: > > On Tue, Jun 25, 2019 at 10:38:31PM -0300, Rodrigo Siqueira wrote: > > > The compute_crc() function is responsible for calculating the > > > framebuffer CRC value; due to the XRGB format, this

Re: [PATCH V3 4/5] drm/vkms: Compute CRC without change input data

2019-07-11 Thread Rodrigo Siqueira
On 07/11, Daniel Vetter wrote: > On Tue, Jun 25, 2019 at 10:38:31PM -0300, Rodrigo Siqueira wrote: > > The compute_crc() function is responsible for calculating the > > framebuffer CRC value; due to the XRGB format, this function has to > > ignore the alpha channel during the CRC computation.

Re: [PATCH V3 4/5] drm/vkms: Compute CRC without change input data

2019-07-11 Thread Daniel Vetter
On Thu, Jul 11, 2019 at 10:28 AM Simon Ser wrote: > > On Thursday, July 11, 2019 11:21 AM, Daniel Vetter wrote: > > > On Tue, Jun 25, 2019 at 10:38:31PM -0300, Rodrigo Siqueira wrote: > > > > > The compute_crc() function is responsible for calculating the > > > framebuffer CRC value; due to the

Re: [PATCH V3 4/5] drm/vkms: Compute CRC without change input data

2019-07-11 Thread Simon Ser
On Thursday, July 11, 2019 11:21 AM, Daniel Vetter wrote: > On Tue, Jun 25, 2019 at 10:38:31PM -0300, Rodrigo Siqueira wrote: > > > The compute_crc() function is responsible for calculating the > > framebuffer CRC value; due to the XRGB format, this function has to > > ignore the alpha channel

Re: [PATCH V3 4/5] drm/vkms: Compute CRC without change input data

2019-07-11 Thread Daniel Vetter
On Tue, Jun 25, 2019 at 10:38:31PM -0300, Rodrigo Siqueira wrote: > The compute_crc() function is responsible for calculating the > framebuffer CRC value; due to the XRGB format, this function has to > ignore the alpha channel during the CRC computation. Therefore, > compute_crc() set zero to the

Re: [PATCH V3 4/5] drm/vkms: Compute CRC without change input data

2019-07-09 Thread Vasilev, Oleg
On Tue, 2019-06-25 at 22:38 -0300, Rodrigo Siqueira wrote: > The compute_crc() function is responsible for calculating the > framebuffer CRC value; due to the XRGB format, this function has to > ignore the alpha channel during the CRC computation. Therefore, > compute_crc() set zero to the alpha

[PATCH V3 4/5] drm/vkms: Compute CRC without change input data

2019-06-25 Thread Rodrigo Siqueira
The compute_crc() function is responsible for calculating the framebuffer CRC value; due to the XRGB format, this function has to ignore the alpha channel during the CRC computation. Therefore, compute_crc() set zero to the alpha channel directly in the input framebuffer, which is not a problem