Re: [PATCH V3 6/7] backlight: qcom-wled: add support for short circuit handling

2018-06-21 Thread kgunda
On 2018-06-20 11:17, Vinod wrote: On 19-06-18, 16:43, Kiran Gunda wrote: struct wled { const char *name; struct device *dev; struct regmap *regmap; + struct mutex lock; /* Lock to avoid race from ISR */ the comment is wrong as you avoid race with thread

Re: [PATCH V3 6/7] backlight: qcom-wled: add support for short circuit handling

2018-06-20 Thread Bjorn Andersson
On Tue 19 Jun 04:13 PDT 2018, Kiran Gunda wrote: > Handle the short circuit interrupt and check if the short circuit > interrupt is valid. Re-enable the module to check if it goes > away. Disable the module altogether if the short circuit event > persists. > > Signed-off-by: Kiran Gunda > --- >

Re: [PATCH V3 6/7] backlight: qcom-wled: add support for short circuit handling

2018-06-19 Thread Vinod
On 19-06-18, 16:43, Kiran Gunda wrote: > struct wled { > const char *name; > struct device *dev; > struct regmap *regmap; > + struct mutex lock; /* Lock to avoid race from ISR */ the comment is wrong as you avoid race with thread handler and not the main ISR. The ISR

[PATCH V3 6/7] backlight: qcom-wled: add support for short circuit handling

2018-06-19 Thread Kiran Gunda
Handle the short circuit interrupt and check if the short circuit interrupt is valid. Re-enable the module to check if it goes away. Disable the module altogether if the short circuit event persists. Signed-off-by: Kiran Gunda --- drivers/video/backlight/qcom-wled.c | 130