Re: [PATCH net-next v5 2/6] dt-bindings: net: Brcm ASP 2.0 Ethernet controller

2023-05-31 Thread Justin Chen
On 5/31/23 12:18 PM, Krzysztof Kozlowski wrote: On 25/05/2023 01:01, Justin Chen wrote: From: Florian Fainelli Add a binding document for the Broadcom ASP 2.0 Ethernet controller. Signed-off-by: Florian Fainelli Signed-off-by: Justin Chen --- v5 - Fix compatible string yaml

Re: [PATCH net-next v5 2/6] dt-bindings: net: Brcm ASP 2.0 Ethernet controller

2023-05-31 Thread Florian Fainelli
On 5/31/23 12:31, Krzysztof Kozlowski wrote: On 31/05/2023 21:29, Florian Fainelli wrote: +required: + - reg + - brcm,channel + +additionalProperties: false + +patternProperties: + "^mdio@[0-9a-f]+$": Isn't mdio a property of each ethernet port? Existing users

Re: [PATCH net-next v5 2/6] dt-bindings: net: Brcm ASP 2.0 Ethernet controller

2023-05-31 Thread Krzysztof Kozlowski
On 31/05/2023 21:29, Florian Fainelli wrote: >>> +required: >>> + - reg >>> + - brcm,channel >>> + >>> +additionalProperties: false >>> + >>> +patternProperties: >>> + "^mdio@[0-9a-f]+$": >> >> Isn't mdio a property of each ethernet port? Existing users >>

Re: [PATCH net-next v5 2/6] dt-bindings: net: Brcm ASP 2.0 Ethernet controller

2023-05-31 Thread Florian Fainelli
On 5/31/23 12:18, Krzysztof Kozlowski wrote: On 25/05/2023 01:01, Justin Chen wrote: From: Florian Fainelli Add a binding document for the Broadcom ASP 2.0 Ethernet controller. Signed-off-by: Florian Fainelli Signed-off-by: Justin Chen --- v5 - Fix compatible string yaml format to

Re: [PATCH net-next v5 2/6] dt-bindings: net: Brcm ASP 2.0 Ethernet controller

2023-05-31 Thread Krzysztof Kozlowski
On 25/05/2023 01:01, Justin Chen wrote: > From: Florian Fainelli > > Add a binding document for the Broadcom ASP 2.0 Ethernet > controller. > > Signed-off-by: Florian Fainelli > Signed-off-by: Justin Chen > --- > v5 > - Fix compatible string yaml format to properly capture what we want

Re: [PATCH net-next v5 2/6] dt-bindings: net: Brcm ASP 2.0 Ethernet controller

2023-05-25 Thread Conor Dooley
On Wed, May 24, 2023 at 04:01:49PM -0700, Justin Chen wrote: > From: Florian Fainelli > > Add a binding document for the Broadcom ASP 2.0 Ethernet > controller. > > Signed-off-by: Florian Fainelli > Signed-off-by: Justin Chen > --- > v5 > - Fix compatible string yaml format to properly

[PATCH net-next v5 2/6] dt-bindings: net: Brcm ASP 2.0 Ethernet controller

2023-05-24 Thread Justin Chen
From: Florian Fainelli Add a binding document for the Broadcom ASP 2.0 Ethernet controller. Signed-off-by: Florian Fainelli Signed-off-by: Justin Chen --- v5 - Fix compatible string yaml format to properly capture what we want v4 - Adjust compatible string example to