Re: [PATCH net-next v6 3/6] net: bcmasp: Add support for ASP2.0 Ethernet controller

2023-06-06 Thread Jakub Kicinski
On Tue, 6 Jun 2023 21:22:45 -0700 Justin Chen wrote: > >> Through filters that can be programmed by the Host cpu or co-processor. > > > > How are the filter programmed by the host (in terms of user API)? > > You are stumbling upon my next objective here. This patch set does not > support

Re: [PATCH net-next v6 3/6] net: bcmasp: Add support for ASP2.0 Ethernet controller

2023-06-06 Thread Justin Chen
On 6/6/2023 8:45 PM, Jakub Kicinski wrote: On Tue, 6 Jun 2023 19:33:13 -0700 Justin Chen wrote: Not netdevs per se, but packets can be redirected to an offload co-processor. How is the redirecting configured? Through filters that can be programmed by the Host cpu or co-processor. How

Re: [PATCH net-next v6 3/6] net: bcmasp: Add support for ASP2.0 Ethernet controller

2023-06-06 Thread Jakub Kicinski
On Tue, 6 Jun 2023 19:33:13 -0700 Justin Chen wrote: > >> Not netdevs per se, but packets can be redirected to an offload > >> co-processor. > > > > How is the redirecting configured? > > Through filters that can be programmed by the Host cpu or co-processor. How are the filter programmed by

Re: [PATCH net-next v6 3/6] net: bcmasp: Add support for ASP2.0 Ethernet controller

2023-06-06 Thread Justin Chen
On 6/6/2023 6:54 PM, Jakub Kicinski wrote: On Tue, 6 Jun 2023 18:35:51 -0700 Justin Chen wrote: Also - can you describe how you can have multiple netdevs for the same MAC? Not netdevs per se, but packets can be redirected to an offload co-processor. How is the redirecting configured?

Re: [PATCH net-next v6 3/6] net: bcmasp: Add support for ASP2.0 Ethernet controller

2023-06-06 Thread Jakub Kicinski
On Tue, 6 Jun 2023 18:35:51 -0700 Justin Chen wrote: > > Also - can you describe how you can have multiple netdevs for > > the same MAC? > > Not netdevs per se, but packets can be redirected to an offload > co-processor. How is the redirecting configured? Could you split this patch into

Re: [PATCH net-next v6 3/6] net: bcmasp: Add support for ASP2.0 Ethernet controller

2023-06-06 Thread Justin Chen
On 6/6/2023 5:16 PM, Jakub Kicinski wrote: On Tue, 6 Jun 2023 15:58:21 -0700 Justin Chen wrote: On 6/2/23 11:58 PM, Jakub Kicinski wrote: On Thu, 1 Jun 2023 15:12:28 -0700 Justin Chen wrote: + /* general stats */ + STAT_NETDEV(rx_packets), + STAT_NETDEV(tx_packets), +

Re: [PATCH net-next v6 3/6] net: bcmasp: Add support for ASP2.0 Ethernet controller

2023-06-06 Thread Jakub Kicinski
On Tue, 6 Jun 2023 15:58:21 -0700 Justin Chen wrote: > On 6/2/23 11:58 PM, Jakub Kicinski wrote: > > On Thu, 1 Jun 2023 15:12:28 -0700 Justin Chen wrote: > >> + /* general stats */ > >> + STAT_NETDEV(rx_packets), > >> + STAT_NETDEV(tx_packets), > >> + STAT_NETDEV(rx_bytes), > >> +

Re: [PATCH net-next v6 3/6] net: bcmasp: Add support for ASP2.0 Ethernet controller

2023-06-06 Thread Justin Chen
On 6/2/23 11:58 PM, Jakub Kicinski wrote: On Thu, 1 Jun 2023 15:12:28 -0700 Justin Chen wrote: + /* general stats */ + STAT_NETDEV(rx_packets), + STAT_NETDEV(tx_packets), + STAT_NETDEV(rx_bytes), + STAT_NETDEV(tx_bytes), + STAT_NETDEV(rx_errors), +

Re: [PATCH net-next v6 3/6] net: bcmasp: Add support for ASP2.0 Ethernet controller

2023-06-05 Thread Florian Fainelli
On 6/2/2023 11:58 PM, Jakub Kicinski wrote: On Thu, 1 Jun 2023 15:12:28 -0700 Justin Chen wrote: + /* general stats */ + STAT_NETDEV(rx_packets), + STAT_NETDEV(tx_packets), + STAT_NETDEV(rx_bytes), + STAT_NETDEV(tx_bytes), + STAT_NETDEV(rx_errors), +

Re: [PATCH net-next v6 3/6] net: bcmasp: Add support for ASP2.0 Ethernet controller

2023-06-03 Thread Jakub Kicinski
On Thu, 1 Jun 2023 15:12:28 -0700 Justin Chen wrote: > + /* general stats */ > + STAT_NETDEV(rx_packets), > + STAT_NETDEV(tx_packets), > + STAT_NETDEV(rx_bytes), > + STAT_NETDEV(tx_bytes), > + STAT_NETDEV(rx_errors), > + STAT_NETDEV(tx_errors), > +

Re: [PATCH net-next v6 3/6] net: bcmasp: Add support for ASP2.0 Ethernet controller

2023-06-03 Thread Jakub Kicinski
On Thu, 1 Jun 2023 15:12:28 -0700 Justin Chen wrote: > + ports_node = of_find_node_by_name(dev->of_node, "ethernet-ports"); > + if (!ports_node) { > + dev_warn(dev, "No ports found\n"); > + return 0; > + } > + > +

[PATCH net-next v6 3/6] net: bcmasp: Add support for ASP2.0 Ethernet controller

2023-06-01 Thread Justin Chen
Add support for the Broadcom ASP 2.0 Ethernet controller which is first introduced with 72165. This controller features two distinct Ethernet ports that can be independently operated. This patch supports: - Wake-on-LAN using magic packets - basic ethtool operations (link, counters, message