Re: [PATCH v1 1/3] drm/msm: Attach the IOMMU device during initialization

2020-05-23 Thread Rob Clark
On Sat, May 23, 2020 at 12:23 AM Shawn Guo wrote: > > On Fri, May 22, 2020 at 04:03:14PM -0600, Jordan Crouse wrote: > > diff --git a/drivers/gpu/drm/msm/msm_gpummu.c > > b/drivers/gpu/drm/msm/msm_gpummu.c > > index 34980d8eb7ad..0ad0f848560a 100644 > > --- a/drivers/gpu/drm/msm/msm_gpummu.c > >

Re: [PATCH v1 1/3] drm/msm: Attach the IOMMU device during initialization

2020-05-23 Thread Shawn Guo
On Fri, May 22, 2020 at 04:03:14PM -0600, Jordan Crouse wrote: > diff --git a/drivers/gpu/drm/msm/msm_gpummu.c > b/drivers/gpu/drm/msm/msm_gpummu.c > index 34980d8eb7ad..0ad0f848560a 100644 > --- a/drivers/gpu/drm/msm/msm_gpummu.c > +++ b/drivers/gpu/drm/msm/msm_gpummu.c > @@ -21,11 +21,6 @@

[PATCH v1 1/3] drm/msm: Attach the IOMMU device during initialization

2020-05-22 Thread Jordan Crouse
Everywhere an IOMMU object is created by msm_gpu_create_address_space the IOMMU device is attached immediately after. Instead of carrying around the infrastructure to do the attach from the device specific code do it directly in the msm_iommu_init() function. This gets it out of the way for more